Windows install_static refactor.

chrome/install_static/product_install_details.h

Index: chrome/install_static/product_install_details.h
diff --git a/chrome/install_static/product_install_details.h b/chrome/install_static/product_install_details.h
new file mode 100644
index 0000000000000000000000000000000000000000..809d036741b05584e0df80beb254c74c4e5240e9
--- /dev/null
+++ b/chrome/install_static/product_install_details.h
@@ -0,0 +1,48 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Contains functions for determining the product's InstallDetails at runtime.
+
+#ifndef CHROME_INSTALL_STATIC_PRODUCT_INSTALL_DETAILS_H_
+#define CHROME_INSTALL_STATIC_PRODUCT_INSTALL_DETAILS_H_
+
+#include <memory>
+#include <string>
+
+namespace install_static {
+
+struct InstallConstants;
+class PrimaryInstallDetails;
+
+// Creates product details for the current process and sets them as the global
+// InstallDetails for the process.
+void InitializeModuleProductDetails();
+
+// Functions from here on down are exposed for the sake of testing.

[robertshield, 2016/10/17 05:27:23]

What's the current thinking. re calling things XXXForTesting when they're
exposed for testing?

[grt (UTC plus 2), 2016/10/24 11:17:51]

I thought it'd be fugly to put that on each of these. There's no inherent reason
why they're not suitable for general consumption, there just aren't other
consumers at the moment. Do you think I should remove the comment? I could also
put them into an "internal" namespace. I don't really care for that too much.

[robertshield, 2016/10/24 14:59:26]

If they're suitable for external consumption, I'd drop the comment on line 22. 

Folk aren't guaranteed to notice it and update it if they do start calling any
of the below. Stuffing stuff in a namespace / renaming the methods is only
needed if we really don't want them called by non-testing code imo.

[grt (UTC plus 2), 2016/10/24 19:36:00]

Done.
Ack.

+
+// Returns true if |parent| is a parent of |path|. Path separators at the end of
+// |parent| are ignored. Returns false if |parent| is empty.
+bool IsPathParentOf(const wchar_t* parent,
+                    size_t parent_len,
+                    const std::wstring& path);
+
+// Returns true if |path| is within C:\Program Files{, (x86)}.
+bool PathIsInProgramFiles(const std::wstring& path);
+
+// Returns the install suffix embedded in |exe_path| or an empty string if none
+// is found. |exe_path| is expected be something similar to
+// "...\[kProductName][suffix]\Application".
+std::wstring GetInstallSuffix(const std::wstring& exe_path);
+
+// Returns true if the browser of |mode| at |system_level| is registered as
+// being multi-install.
+bool IsMultiInstall(const InstallConstants& mode, bool system_level);
+
+// Creates product details for the process at |exe_path|.
+std::unique_ptr<PrimaryInstallDetails> MakeProductDetails(
+    const std::wstring& exe_path);
+
+}  // namespace install_static
+
+#endif  // CHROME_INSTALL_STATIC_PRODUCT_INSTALL_DETAILS_H_