Windows install_static refactor.

chrome/app/chrome_crash_reporter_client_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(ananta/scottmg)
 // Add test coverage for Crashpad.
 #include "chrome/app/chrome_crash_reporter_client_win.h"
 
 #include <assert.h>
 #include <windows.h>
 #include <shellapi.h>
 #include <memory>
 #include <string>
 
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
 #include "base/debug/leak_annotations.h"
 #include "base/format_macros.h"
 #include "chrome/common/chrome_result_codes.h"
+#include "chrome/install_static/install_details.h"
 #include "chrome/install_static/install_util.h"
 #include "components/crash/content/app/crashpad.h"
 #include "components/crash/core/common/crash_keys.h"
 
 namespace {
 
 // TODO(ananta)
 // When the new crash key map implementation lands, we should remove the
 // constants defined below, the RegisterCrashKeysHelper function, the
 // RegisterCrashKeys function in the crash_keys::CrashReporterClient interface
@@ skipping 270 matching lines @@
 
   install_static::SetEnvironmentString16(install_static::kShowRestart, L"1");
   return true;
 }
 
 bool ChromeCrashReporterClient::GetDeferredUploadsSupported(
     bool is_per_user_install) {
   return false;
 }
 
+// TODO(grt): Remove |exe_path| from crash_reporter::CrashReporterClient.
 bool ChromeCrashReporterClient::GetIsPerUserInstall(
     const base::string16& exe_path) {
-  return !install_static::IsSystemInstall(exe_path.c_str());
+  return !install_static::InstallDetails::Get().system_level();
 }
 
+// TODO(grt): Remove |is_per_user_install| from
+// crash_reporter::CrashReporterClient.

[robertshield, 2016/10/24 13:56:21]

Consider sticking these TODOs on CrashReporterClient?

[grt (UTC plus 2), 2016/10/24 19:36:00]

I was trying to keep the size of the CL in check by doing it here. I plan to
address this TODO in a subsequent change as I ripple InstallDetails through the
product and installer. Are you okay with keeping it here for now?

[robertshield, 2016/10/28 06:56:52]

Oh, sure, that's fine too since the winds of change are blowing and all that. 

If you postpone subsequent changes for reasons, consider moving the TODOs at
some point in the future.

[grt (UTC plus 2), 2016/10/28 10:59:44]

Will do. I plan for the next CL to be the one that brings InstallDetails into
setup.exe. Once that's there, I can clean up CrashReporterClient with ease. It
shouldn't be too long.

 bool ChromeCrashReporterClient::GetShouldDumpLargerDumps(
     bool is_per_user_install) {
-  base::string16 channel_name;
-  install_static::GetChromeChannelName(is_per_user_install,
-                                       false, // !add_modifier
-                                       &channel_name);
-  // Capture more detail in crash dumps for Beta, Dev, Canary channels and
-  // if channel is unknown (e.g. Chromium or developer builds).
-  return (channel_name == install_static::kChromeChannelBeta ||
-          channel_name == install_static::kChromeChannelDev ||
-          channel_name == install_static::kChromeChannelCanary ||
-          channel_name == install_static::kChromeChannelUnknown);
+  // Capture larger dumps for:
+  // - Chromium builds: "unknown" channel
+  // - Google Chrome builds: "beta", "dev", and "canary" channels.
+  // That leaves stable channel, which is the empty string.
+  return !install_static::InstallDetails::Get().channel().empty();
 }
 
 int ChromeCrashReporterClient::GetResultCodeRespawnFailed() {
   return chrome::RESULT_CODE_RESPAWN_FAILED;
 }
 
 bool ChromeCrashReporterClient::ReportingIsEnforcedByPolicy(
     bool* crashpad_enabled) {
   // Determine whether configuration management allows loading the crash
   // reporter.
@@ skipping 44 matching lines @@
 bool ChromeCrashReporterClient::GetCollectStatsInSample() {
   return install_static::GetCollectStatsInSample();
 }
 
 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
     const std::string& process_type) {
   return process_type == install_static::kRendererProcess ||
          process_type == install_static::kPpapiPluginProcess ||
          process_type == install_static::kGpuProcess;
 }