Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: Source/devtools/blink/chromeServerProfile/Default/Cache/f_000072

Issue 242263007: Add <label> to items in Event Listener Breakpoint of Chrome Dev Tools Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/blink/chromeServerProfile/Default/Cache/f_000072
diff --git a/Source/devtools/front_end/SourcesView.js b/Source/devtools/blink/chromeServerProfile/Default/Cache/f_000072
similarity index 95%
copy from Source/devtools/front_end/SourcesView.js
copy to Source/devtools/blink/chromeServerProfile/Default/Cache/f_000072
index 6d2c14b688269ffe0a451fac0a85efd4d50e6e19..67f3f3c50ccda8aa32040533683e52d6b698e775 100644
--- a/Source/devtools/front_end/SourcesView.js
+++ b/Source/devtools/blink/chromeServerProfile/Default/Cache/f_000072
@@ -25,7 +25,7 @@ WebInspector.SourcesView = function(workspace, sourcesPanel)
this._searchableView.setMinimalSearchQuerySize(0);
this._searchableView.show(this.element);
- /** @type {!Map.<!WebInspector.UISourceCode, !WebInspector.UISourceCodeFrame>} */
+ /** @type {!Map.<!WebInspector.UISourceCode, !WebInspector.SourceFrame>} */
this._sourceFramesByUISourceCode = new Map();
var tabbedEditorPlaceholderText = WebInspector.isMac() ? WebInspector.UIString("Hit Cmd+O to open a file") : WebInspector.UIString("Hit Ctrl+O to open a file");
@@ -114,7 +114,6 @@ WebInspector.SourcesView.prototype = {
registerShortcut.call(this, WebInspector.ShortcutsScreen.SourcesPanelShortcuts.GoToMember, this._showOutlineDialog.bind(this));
registerShortcut.call(this, WebInspector.ShortcutsScreen.SourcesPanelShortcuts.ToggleBreakpoint, this._toggleBreakpoint.bind(this));
registerShortcut.call(this, WebInspector.ShortcutsScreen.SourcesPanelShortcuts.Save, this._save.bind(this));
- registerShortcut.call(this, WebInspector.ShortcutsScreen.SourcesPanelShortcuts.SaveAll, this._saveAll.bind(this));
},
/**
@@ -252,11 +251,11 @@ WebInspector.SourcesView.prototype = {
*/
_removeUISourceCodes: function(uiSourceCodes)
{
- this._editorContainer.removeUISourceCodes(uiSourceCodes);
for (var i = 0; i < uiSourceCodes.length; ++i) {
this._removeSourceFrame(uiSourceCodes[i]);
this._historyManager.removeHistoryForSourceCode(uiSourceCodes[i]);
}
+ this._editorContainer.removeUISourceCodes(uiSourceCodes);
},
_projectWillReset: function(event)
@@ -325,7 +324,7 @@ WebInspector.SourcesView.prototype = {
/**
* @param {!WebInspector.UISourceCode} uiSourceCode
- * @return {!WebInspector.UISourceCodeFrame}
+ * @return {!WebInspector.SourceFrame}
*/
_createSourceFrame: function(uiSourceCode)
{
@@ -352,7 +351,7 @@ WebInspector.SourcesView.prototype = {
/**
* @param {!WebInspector.UISourceCode} uiSourceCode
- * @return {!WebInspector.UISourceCodeFrame}
+ * @return {!WebInspector.SourceFrame}
*/
_getOrCreateSourceFrame: function(uiSourceCode)
{
@@ -485,9 +484,8 @@ WebInspector.SourcesView.prototype = {
/**
* @param {string} query
* @param {boolean} shouldJump
- * @param {boolean=} jumpBackwards
*/
- performSearch: function(query, shouldJump, jumpBackwards)
+ performSearch: function(query, shouldJump)
{
this._searchableView.updateSearchMatchesCount(0);
@@ -528,7 +526,7 @@ WebInspector.SourcesView.prototype = {
this._searchableView.cancelSearch();
}
- this._searchView.performSearch(query, shouldJump, !!jumpBackwards, finishedCallback.bind(this), currentMatchChanged.bind(this), searchResultsChanged.bind(this));
+ this._searchView.performSearch(query, shouldJump, finishedCallback.bind(this), currentMatchChanged.bind(this), searchResultsChanged.bind(this));
},
jumpToNextSearchResult: function()
@@ -636,32 +634,16 @@ WebInspector.SourcesView.prototype = {
*/
_save: function()
{
- this._saveSourceFrame(this.currentSourceFrame());
- return true;
- },
-
- /**
- * @return {boolean}
- */
- _saveAll: function()
- {
- var sourceFrames = this._editorContainer.fileViews();
- sourceFrames.forEach(this._saveSourceFrame.bind(this));
- return true;
- },
-
- /**
- * @param {?WebInspector.SourceFrame} sourceFrame
- */
- _saveSourceFrame: function(sourceFrame)
- {
+ var sourceFrame = this.currentSourceFrame();
if (!sourceFrame)
- return;
+ return true;
if (!(sourceFrame instanceof WebInspector.UISourceCodeFrame))
- return;
+ return true;
var uiSourceCodeFrame = /** @type {!WebInspector.UISourceCodeFrame} */ (sourceFrame);
uiSourceCodeFrame.commitEditing();
+ return true;
},
+
/**
* @return {boolean}
*/

Powered by Google App Engine
This is Rietveld 408576698