Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2422593003: Remove --log-regexp. (Closed)

Created:
4 years, 2 months ago by Yang
Modified:
4 years, 2 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --log-regexp. There is no user for this log entry, and a large part of regexp log output has long been removed already. R=jgruber@chromium.org Committed: https://crrev.com/b3852ab3b499089f594fff34727e6fe77e6bafca Cr-Commit-Position: refs/heads/master@{#40316}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -72 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/log.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/log.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M src/log-utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/log-utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/regexp/jsregexp.cc View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Yang
4 years, 2 months ago (2016-10-14 11:08:32 UTC) #1
jgruber
lgtm
4 years, 2 months ago (2016-10-14 11:42:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422593003/1
4 years, 2 months ago (2016-10-14 11:46:27 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/26576)
4 years, 2 months ago (2016-10-14 12:03:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422593003/1
4 years, 2 months ago (2016-10-14 12:28:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/10734) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-10-14 12:40:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422593003/20001
4 years, 2 months ago (2016-10-14 12:52:50 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 13:26:18 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 13:26:44 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3852ab3b499089f594fff34727e6fe77e6bafca
Cr-Commit-Position: refs/heads/master@{#40316}

Powered by Google App Engine
This is Rietveld 408576698