Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2422573002: [builtins] Remove template argument from args.target(). (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Remove template argument from args.target(). It's always JSFunction. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/b61baa9e3270ac123349ab1504a2c07dbfbbca4d Cr-Commit-Position: refs/heads/master@{#40301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M src/builtins/builtins-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-arraybuffer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-boolean.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-dataview.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-date.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-error.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-function.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-global.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-utils.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 2 months ago (2016-10-14 08:33:20 UTC) #1
Benedikt Meurer
LGTM!
4 years, 2 months ago (2016-10-14 08:34:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422573002/1
4 years, 2 months ago (2016-10-14 08:34:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 09:01:28 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 09:01:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b61baa9e3270ac123349ab1504a2c07dbfbbca4d
Cr-Commit-Position: refs/heads/master@{#40301}

Powered by Google App Engine
This is Rietveld 408576698