Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2422563002: [regexp] Simplify GetCapture (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Simplify GetCapture GetCapture can reuse the bool pointer argument of GenericCaptureGetter instead of duplicating that logic with additional checks. The check also incorrectly checks for undefined while GenericCaptureGetter returns the empty string on failure. BUG=v8:5339 Committed: https://crrev.com/b182ab83029d0c225fbe33844089e0824d918bec Cr-Commit-Position: refs/heads/master@{#40309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/runtime/runtime-regexp.cc View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jgruber
4 years, 2 months ago (2016-10-14 08:39:13 UTC) #4
Yang
lgtm
4 years, 2 months ago (2016-10-14 11:35:23 UTC) #7
Yang
lgtm lgtm
4 years, 2 months ago (2016-10-14 11:35:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422563002/1
4 years, 2 months ago (2016-10-14 11:45:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 11:47:58 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 11:48:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b182ab83029d0c225fbe33844089e0824d918bec
Cr-Commit-Position: refs/heads/master@{#40309}

Powered by Google App Engine
This is Rietveld 408576698