Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2422543002: Remove usage of FOR_EACH_OBSERVER macro in apps/ (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in apps/ Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/01080f9de6ea0553025c24725219823e911c6aa5 Cr-Commit-Position: refs/heads/master@{#425802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M apps/app_lifetime_monitor.cc View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Eric Willigers
4 years, 2 months ago (2016-10-14 06:51:19 UTC) #6
asargent_no_longer_on_chrome
lgtm
4 years, 2 months ago (2016-10-17 20:39:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422543002/1
4 years, 2 months ago (2016-10-17 21:32:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 22:55:34 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 22:58:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01080f9de6ea0553025c24725219823e911c6aa5
Cr-Commit-Position: refs/heads/master@{#425802}

Powered by Google App Engine
This is Rietveld 408576698