Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2422533003:
[tools/perf] Add script that lists out all the system health stories (Closed)
Description[tools/perf] Add script that lists out all the system health stories
BUG=589726
Committed: https://crrev.com/715334fbf73bb6532d8aff06caf99331ddbe78b5
Cr-Commit-Position: refs/heads/master@{#426781}
Patch Set 1 #
Total comments: 7
Patch Set 2 : Address Juan comment #Patch Set 3 : rebase error #Messages
Total messages: 20 (13 generated)
nednguyen@google.com changed reviewers: + hjd@chromium.org, perezju@chromium.org
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Description was changed from ========== [tools/perf] Add script that list out all the system health stories BUG=589726 ========== to ========== [tools/perf] Add script that lists out all the system health stories BUG=589726 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2422533003/diff/1/tools/perf/list_system_heal... File tools/perf/list_system_health_stories (right): https://codereview.chromium.org/2422533003/diff/1/tools/perf/list_system_heal... tools/perf/list_system_health_stories:12: nit: these should be 2 blank lines. https://codereview.chromium.org/2422533003/diff/1/tools/perf/list_system_heal... tools/perf/list_system_health_stories:18: yield s There are some stories that have support for both desktop and mobile, but are implemented as separate classes; this causes in the output: browse:media:imgur desktop browse:media:imgur mobile where perhaps we would like to have browse:media:imgur all https://codereview.chromium.org/2422533003/diff/1/tools/perf/list_system_heal... tools/perf/list_system_health_stories:19: nit: 2 blank lines
https://codereview.chromium.org/2422533003/diff/1/tools/perf/list_system_heal... File tools/perf/list_system_health_stories (right): https://codereview.chromium.org/2422533003/diff/1/tools/perf/list_system_heal... tools/perf/list_system_health_stories:12: On 2016/10/17 08:28:54, perezju wrote: > nit: these should be 2 blank lines. Done. https://codereview.chromium.org/2422533003/diff/1/tools/perf/list_system_heal... tools/perf/list_system_health_stories:18: yield s On 2016/10/17 08:28:54, perezju wrote: > There are some stories that have support for both desktop and mobile, but are > implemented as separate classes; this causes in the output: > > browse:media:imgur desktop > browse:media:imgur mobile > > where perhaps we would like to have > > browse:media:imgur all They are listed differently because the workflow are a bit different, so I think we should separate them. https://codereview.chromium.org/2422533003/diff/1/tools/perf/list_system_heal... tools/perf/list_system_health_stories:19: On 2016/10/17 08:28:54, perezju wrote: > nit: 2 blank lines Done.
lgtm w/comment https://codereview.chromium.org/2422533003/diff/1/tools/perf/list_system_heal... File tools/perf/list_system_health_stories (right): https://codereview.chromium.org/2422533003/diff/1/tools/perf/list_system_heal... tools/perf/list_system_health_stories:18: yield s On 2016/10/21 11:34:48, nednguyen wrote: > On 2016/10/17 08:28:54, perezju wrote: > > There are some stories that have support for both desktop and mobile, but are > > implemented as separate classes; this causes in the output: > > > > browse:media:imgur desktop > > browse:media:imgur mobile > > > > where perhaps we would like to have > > > > browse:media:imgur all > > They are listed differently because the workflow are a bit different, so I think > we should separate them. To me sounds like an implementation detail leaking when you only want to "get a list of stories". Depending on the intended usage of the script, this might surprise users. Don't have a strong objection if you want to land as-is.
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from perezju@chromium.org Link to the patchset: https://codereview.chromium.org/2422533003/#ps40001 (title: "rebase error")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Add script that lists out all the system health stories BUG=589726 ========== to ========== [tools/perf] Add script that lists out all the system health stories BUG=589726 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Add script that lists out all the system health stories BUG=589726 ========== to ========== [tools/perf] Add script that lists out all the system health stories BUG=589726 Committed: https://crrev.com/715334fbf73bb6532d8aff06caf99331ddbe78b5 Cr-Commit-Position: refs/heads/master@{#426781} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/715334fbf73bb6532d8aff06caf99331ddbe78b5 Cr-Commit-Position: refs/heads/master@{#426781} |
