|
|
Created:
4 years, 2 months ago by ssid Modified:
4 years, 2 months ago Reviewers:
Primiano Tucci (use gerrit) CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, oystein (OOO til 10th of July) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[tracing] Whitelist android ResourceManagerImpl dump provider for field trials.
BUG=654640
R=primiano@chromium.org
Committed: https://crrev.com/ae1e2192c4d9bc962ecc4e0b82a0bd5ba153577c
Cr-Commit-Position: refs/heads/master@{#425479}
Patch Set 1 : . #
Depends on Patchset: Messages
Total messages: 17 (8 generated)
Description was changed from ========== [tracing] Whitelist android ResourceManagerImpl dump provider for field trials. BUG=654640 R=primiano@chromium.org ========== to ========== [tracing] Whitelist android ResourceManagerImpl dump provider for field trials. BUG=654640 R=primiano@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== [tracing] Whitelist android ResourceManagerImpl dump provider for field trials. BUG=654640 R=primiano@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== [tracing] Whitelist android ResourceManagerImpl dump provider for field trials. BUG=654640 R=primiano@chromium.org ==========
ptal, thanks.
I had no idea he android::ResourceManager thing happened :) this LGTM (+oysteine@ FYI) Maybe, since we are still in time, can we just change the name of that thing to AndroidResourceManager? We never used ::scope things so far, maybe we can stay consistent
On 2016/10/14 09:20:57, Primiano Tucci wrote: > I had no idea he android::ResourceManager thing happened :) > this LGTM (+oysteine@ FYI) > Maybe, since we are still in time, can we just change the name of that thing to > AndroidResourceManager? We never used ::scope things so far, maybe we can stay > consistent Sorry I'll keep you in loop. We had meeting with Reed since I just found him in MTV. He suggested this should be accounted from outside skia since they don't keep track. I added it yesterday. The issue is there are so many resources managers and even in cc there are different in implementations. We use scoped names in cc dump providers in general. we have lot of names with cc::
On 2016/10/14 13:36:29, ssid wrote: > On 2016/10/14 09:20:57, Primiano Tucci wrote: > > I had no idea he android::ResourceManager thing happened :) > > this LGTM (+oysteine@ FYI) > > Maybe, since we are still in time, can we just change the name of that thing > to > > AndroidResourceManager? We never used ::scope things so far, maybe we can stay > > consistent > > Sorry I'll keep you in loop. We had meeting with Reed since I just found him in > MTV. He suggested this should be accounted from outside skia since they don't > keep track. > I added it yesterday. The issue is there are so many resources managers and even > in cc there are different in implementations. We use scoped names in cc dump > providers in general. we have lot of names with cc:: ah ok then
The CQ bit was checked by ssid@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by ssid@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [tracing] Whitelist android ResourceManagerImpl dump provider for field trials. BUG=654640 R=primiano@chromium.org ========== to ========== [tracing] Whitelist android ResourceManagerImpl dump provider for field trials. BUG=654640 R=primiano@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [tracing] Whitelist android ResourceManagerImpl dump provider for field trials. BUG=654640 R=primiano@chromium.org ========== to ========== [tracing] Whitelist android ResourceManagerImpl dump provider for field trials. BUG=654640 R=primiano@chromium.org Committed: https://crrev.com/ae1e2192c4d9bc962ecc4e0b82a0bd5ba153577c Cr-Commit-Position: refs/heads/master@{#425479} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ae1e2192c4d9bc962ecc4e0b82a0bd5ba153577c Cr-Commit-Position: refs/heads/master@{#425479} |