Chromium Code Reviews| Index: chrome/browser/resources/settings/internet_page/network_nameservers.js |
| diff --git a/chrome/browser/resources/settings/internet_page/network_nameservers.js b/chrome/browser/resources/settings/internet_page/network_nameservers.js |
| index cec1b79e122d21cecc6415778cdc043a749703fb..1ec12875edd2607a628afb7e6e927effc295ee93 100644 |
| --- a/chrome/browser/resources/settings/internet_page/network_nameservers.js |
| +++ b/chrome/browser/resources/settings/internet_page/network_nameservers.js |
| @@ -43,6 +43,7 @@ Polymer({ |
| nameserversType_: { |
| type: String, |
| value: 'automatic', |
| + observer: 'nameserversTypeChanged_', |
| }, |
| /** |
| @@ -102,6 +103,11 @@ Polymer({ |
| this.setNameservers_(type, nameservers); |
| }, |
| + /** @private */ |
| + nameserversTypeChanged_: function() { |
| + this.$.nameserverType.value = this.nameserversType_; |
|
dpapad
2016/10/17 22:57:05
I don't think this observer needed? You can use a
stevenjb
2016/10/17 23:10:19
Hmm, I'm not sure I understand how using data bind
stevenjb
2016/10/17 23:58:01
After looking over the settings-dropdown-menu impl
|
| + }, |
| + |
| /** |
| * @param {string} nameserversType |
| * @param {!Array<string>} nameservers |
| @@ -142,13 +148,13 @@ Polymer({ |
| /** |
| * Event triggered when the selected type changes. Updates nameservers and |
| * sends the change value if necessary. |
| - * @param {!{detail: !{selected: string}}} e |
| + * @param {!{target: !{value: string}}} e |
|
dpapad
2016/10/17 22:57:05
Same here.
stevenjb
2016/10/17 23:58:01
Acknowledged.
|
| * @private |
| */ |
| onTypeChange_: function(e) { |
| if (this.nameserversType_ == 'custom') |
| this.savedNameservers_ = this.nameservers_; |
| - var type = e.detail.selected; |
| + var type = e.target.value; |
| this.nameserversType_ = type; |
| if (type == 'custom') { |
| // Restore the saved nameservers. |