Use md-select instead of paper-dropdown-menu-light in internet page

chrome/browser/resources/settings/internet_page/network_proxy.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Polymer element for displaying and editing network proxy
  * values.
  */
 Polymer({
   is: 'network-proxy',
@@ skipping 84 matching lines @@
    */
   savedManual_: undefined,
 
   /**
    * Saved ExcludeDomains properties so that switching to a non-Manual type does
    * not loose any set exclusions while the UI is open.
    * @private {!Array<string>|undefined}
    */
   savedExcludeDomains_: undefined,
 
-  /**
-   * Polymer networkProperties changed method.
-   */
+  /** @private */
   networkPropertiesChanged_: function() {
     if (!this.networkProperties)
       return;
 
     /** @type {!CrOnc.ProxySettings} */
     var proxy = this.createDefaultProxySettings_();
     /** @type {!chrome.networkingPrivate.ManagedProxySettings|undefined} */
     var proxySettings = this.networkProperties.ProxySettings;
     if (proxySettings) {
       proxy.Type = /** @type {!CrOnc.ProxySettingsType} */ (
@@ skipping 14 matching lines @@
         proxy.ExcludeDomains = /** @type {!Array<string>|undefined} */ (
             CrOnc.getActiveValue(proxySettings.ExcludeDomains));
       }
       proxy.PAC = /** @type {string|undefined} */ (
           CrOnc.getActiveValue(proxySettings.PAC));
     }
     // Use saved ExcludeDomanains and Manual if not defined.
     proxy.ExcludeDomains = proxy.ExcludeDomains || this.savedExcludeDomains_;
     proxy.Manual = proxy.Manual || this.savedManual_;
 
-    this.proxy = proxy;
+    // Set this.proxy after dom-repeat has been stamped.
+    this.async(function() {
+      this.proxy = proxy;
+    }.bind(this));
 
     // Set the Web Proxy Auto Discovery URL.
     var ipv4 =
         CrOnc.getIPConfigForType(this.networkProperties, CrOnc.IPType.IPV4);
     this.WPAD = (ipv4 && ipv4.WebProxyAutoDiscoveryUrl) || '';
   },
 
+  /** @private */
+  useSameProxyChanged_: function() {

[dpapad, 2016/10/18 00:09:51]

Nit: This seems to have been moved, no modification. Consider reverting to make
diff smaller (unless you are moving intentionally to a more intuitive method
ordering).

[stevenjb, 2016/10/18 00:32:57]

I've been fixing ordering and comments to be consistent with other JS files.
I've been doing this as I go in places that got missed by a (semi) recent
consistency pass.

+    this.sendProxyChange_();
+  },
+
   /**
    * @return {CrOnc.ProxySettings} An empty/default proxy settings object.
+   * @private
    */
   createDefaultProxySettings_: function() {
     return {
       Type: CrOnc.ProxySettingsType.DIRECT,
       ExcludeDomains: [],
       Manual: {
         HTTPProxy: {Host: '', Port: 80},
         SecureHTTPProxy: {Host: '', Port: 80},
         FTPProxy: {Host: '', Port: 80},
         SOCKS: {Host: '', Port: 1080}
       },
       PAC: ''
     };
   },
 
   /**
-   * Polymer useSameProxy changed method.
-   */
-  useSameProxyChanged_: function() {
-    this.sendProxyChange_();
-  },
-
-  /**
    * Called when the proxy changes in the UI.
+   * @private
    */
   sendProxyChange_: function() {
     if (this.proxy.Type == CrOnc.ProxySettingsType.MANUAL) {
       var proxy =
           /** @type {!CrOnc.ProxySettings} */ (Object.assign({}, this.proxy));
       var defaultProxy = proxy.Manual.HTTPProxy;
       if (!defaultProxy || !defaultProxy.Host)
         return;
       if (this.useSameProxy_ || !proxy.Manual.SecureHTTPProxy) {
         proxy.Manual.SecureHTTPProxy = /** @type {!CrOnc.ProxyLocation} */ (
@@ skipping 12 matching lines @@
       this.proxy = proxy;
     } else if (this.proxy.Type == CrOnc.ProxySettingsType.PAC) {
       if (!this.proxy.PAC)
         return;
     }
     this.fire('proxy-change', {field: 'ProxySettings', value: this.proxy});
   },
 
   /**
    * Event triggered when the selected proxy type changes.
-   * @param {!{detail: !{selected: string}}} e
+   * @param {!Event} event
    * @private
    */
-  onTypeChange_: function(e) {
+  onTypeChange_: function(event) {
+    let target = /** @type {!HTMLSelectElement} */ (event.target);
     var type = /** @type {chrome.networkingPrivate.ProxySettingsType} */ (
-        e.detail.selected);
+        target.value);
     this.set('proxy.Type', type);
     this.sendProxyChange_();
   },
 
   /**
    * Event triggered when a proxy value changes.
    * @param {Event} event The proxy value change event.
    * @private
    */
   onProxyInputChange_: function(event) {
@@ skipping 58 matching lines @@
   /**
    * @param {string} property The property to test
    * @param {string} value The value to test against
    * @return {boolean} True if property == value
    * @private
    */
   matches_: function(property, value) {
     return property == value;
   }
 });