Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2422403002: Revert "Fix file name handling on windows" (Closed)

Created:
4 years, 2 months ago by vsm
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix file name handling on windows" This appears to break on bazel. BUG= R=nshahan@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/a032a4c952b5dd9e2c14034b2a1d75d11413f545

Patch Set 1 #

Patch Set 2 : Regen #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -179 lines) Patch
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 1 chunk +175 lines, -175 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 2 months ago (2016-10-17 22:09:32 UTC) #3
nshahan
lgtm
4 years, 2 months ago (2016-10-17 22:21:47 UTC) #4
vsm
4 years, 2 months ago (2016-10-17 22:27:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a032a4c952b5dd9e2c14034b2a1d75d11413f545 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698