[chromedriver] Fixes for android tests gating chromedriver release.

chrome/test/chromedriver/run_buildbot_steps.py

Index: chrome/test/chromedriver/run_buildbot_steps.py
diff --git a/chrome/test/chromedriver/run_buildbot_steps.py b/chrome/test/chromedriver/run_buildbot_steps.py
index ddc05fdc5cd71ae364c9d24a8f858f0a4d70583a..dcfda2650f4949d17eeb3de7f30de20d2924c41f 100755
--- a/chrome/test/chromedriver/run_buildbot_steps.py
+++ b/chrome/test/chromedriver/run_buildbot_steps.py
@@ -391,8 +391,9 @@ def main():
       help='Comma separated list of application package names, '
            'if running tests on Android.')
   parser.add_option(
-      '-r', '--revision', type='int', default=None,
-      help='Chromium revision')
+      '-r', '--revision', type='int', default=None, help='Chromium revision')

[frankf, 2013/09/18 22:51:07]

default is None

[craigdh, 2013/09/18 22:55:06]

Done.

+  parser.add_option('', '--update-log', action='store_true', default=False,
+      help='Update the test results log (only applicable to Android)')

[frankf, 2013/09/18 22:51:07]

remove default

[craigdh, 2013/09/18 22:55:06]

Done.

   options, _ = parser.parse_args()
 
   bitness = '32'
@@ -407,11 +408,12 @@ def main():
   CleanTmpDir()
 
   if platform == 'android':
+    if not options.revision and options.update_log:
+      parser.error('Must supply a --revision with --update-log')
     DownloadPrebuilts()
   else:
     if not options.revision:
       parser.error('Must supply a --revision')
-
     if platform == 'linux64':
       ArchivePrebuilts(options.revision)
 
@@ -427,7 +429,8 @@ def main():
   passed = (util.RunCommand(cmd) == 0)
 
   if platform == 'android':
-    UpdateTestResultsLog(platform, options.revision, passed)
+    if options.update_log:
+      UpdateTestResultsLog(platform, options.revision, passed)
   elif passed:
     _MaybeUpdateReleaseCandidate(platform, options.revision)
     _MaybeRelease(platform)