Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2422373002: Cleanup unneeded FWL theme code. (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup unneeded FWL theme code. This CL removes FWL theme code methods which do not have implementations. Committed: https://pdfium.googlesource.com/pdfium/+/878dd5b121b38e6eaba5b3f3a90d0a9abf60feaf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -242 lines) Patch
M xfa/fwl/basewidget/fwl_comboboximp.cpp View 2 chunks +6 lines, -15 lines 0 comments Download
M xfa/fwl/basewidget/fwl_listboximp.cpp View 2 chunks +4 lines, -16 lines 0 comments Download
M xfa/fwl/basewidget/fwl_scrollbarimp.cpp View 1 chunk +17 lines, -34 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.cpp View 4 chunks +4 lines, -34 lines 0 comments Download
M xfa/fwl/core/fwl_widgetimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_themeprovider.h View 1 chunk +0 lines, -14 lines 0 comments Download
M xfa/fwl/theme/cfwl_checkboxtp.h View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_checkboxtp.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_monthcalendartp.h View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_monthcalendartp.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_pushbuttontp.h View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_pushbuttontp.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_scrollbartp.h View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_scrollbartp.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.h View 3 chunks +2 lines, -8 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.cpp View 4 chunks +2 lines, -36 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.h View 1 chunk +3 lines, -20 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 8 chunks +10 lines, -38 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-17 21:10:41 UTC) #3
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-17 22:39:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422373002/1
4 years, 2 months ago (2016-10-18 00:40:50 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 01:14:28 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/878dd5b121b38e6eaba5b3f3a90d0a9abf60...

Powered by Google App Engine
This is Rietveld 408576698