Trigger HTTP-bad warning when querying credit card autofill

Trigger HTTP-bad warning when querying credit card autofill

When a user focuses or types in a credit card field, the omnibox should
be updated to say "Not secure". This CL implements that behavior by
notifying the WebContents when the renderer queries for credit card
autofill suggestions.

BUG=648838
Committed: https://crrev.com/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3
Cr-Commit-Position: refs/heads/master@{#425999}

[estark, 2016-10-17 21:06:23]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 21:06:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-10-17 21:07:05]

estark@chromium.org changed reviewers:
+ vabr@chromium.org

[estark, 2016-10-17 21:07:06]

vabr, can you please review? Thanks!

[commit-bot: I haz the power, 2016-10-17 21:17:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 21:17:35]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[estark, 2016-10-17 21:28:53]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 21:29:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 22:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 22:57:56]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-10-18 09:35:23]

LGTM, thank you.
Vaclav

https://codereview.chromium.org/2422363002/diff/20001/components/autofill/con...
File components/autofill/content/browser/content_autofill_driver_unittest.cc
(right):

https://codereview.chromium.org/2422363002/diff/20001/components/autofill/con...
components/autofill/content/browser/content_autofill_driver_unittest.cc:466: //
Tests that credit card form interactions are *not* recorded on the current
nit: Please add a blank line above.

[estark, 2016-10-18 16:34:27]

https://codereview.chromium.org/2422363002/diff/20001/components/autofill/con...
File components/autofill/content/browser/content_autofill_driver_unittest.cc
(right):

https://codereview.chromium.org/2422363002/diff/20001/components/autofill/con...
components/autofill/content/browser/content_autofill_driver_unittest.cc:466: //
Tests that credit card form interactions are *not* recorded on the current
On 2016/10/18 09:35:23, vabr (Chromium) wrote:
> nit: Please add a blank line above.

Done.

[estark, 2016-10-18 16:34:32]

The CQ bit was checked by estark@chromium.org

[estark, 2016-10-18 16:34:33]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2422363002/#ps40001
(title: "add missing blank line")

[commit-bot: I haz the power, 2016-10-18 16:35:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 17:20:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-18 17:23:13]

Description was changed from

==========
Trigger HTTP-bad warning when querying credit card autofill

When a user focuses or types in a credit card field, the omnibox should
be updated to say "Not secure". This CL implements that behavior by
notifying the WebContents when the renderer queries for credit card
autofill suggestions.

BUG=648838
==========

to

==========
Trigger HTTP-bad warning when querying credit card autofill

When a user focuses or types in a credit card field, the omnibox should
be updated to say "Not secure". This CL implements that behavior by
notifying the WebContents when the renderer queries for credit card
autofill suggestions.

BUG=648838

Committed: https://crrev.com/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3
Cr-Commit-Position: refs/heads/master@{#425999}
==========

[commit-bot: I haz the power, 2016-10-18 17:23:14]

Patchset 3 (id:??) landed as
https://crrev.com/056b46cc4acb4cb36f7b8d60392ea097bbf2e3c3
Cr-Commit-Position: refs/heads/master@{#425999}