Issue 2422333002: Remove _functionTypesToFix from ElementBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2422333002: Remove _functionTypesToFix from ElementBuilder. (Closed)

Created:
4 years, 2 months ago by scheglov

Modified:
4 years, 2 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Remove _functionTypesToFix from ElementBuilder. We might have needed it in the past, but now 'new FunctionTypeImpl(element)' does not use the enclosing element, at least until we start calling its methods, which happens after we finish building the element model. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/fabb9dbf18042c1ba7ada20a7e2b0ca0bab35a2f

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -20 lines)			Patch
	M	pkg/analyzer/lib/src/dart/element/builder.dart	View		4 chunks	+1 line, -20 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as fabb9dbf18042c1ba7ada20a7e2b0ca0bab35a2f (presubmit successful).

4 years, 2 months ago (2016-10-17 21:26:46 UTC) #4

Message was sent while issue was closed.

lgtm