Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2422323002: Don't handle DCHECK failure. (Closed)

Created:
4 years, 2 months ago by Peter Kasting
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, jdonnelly+autofillwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't handle DCHECK failure. BUG=none TEST=none Committed: https://crrev.com/f38c80506465dbf4db63ad795bd94cc7fdf3673a Cr-Commit-Position: refs/heads/master@{#425811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M components/webdata/common/web_data_request_manager.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Peter Kasting
4 years, 2 months ago (2016-10-17 20:40:42 UTC) #4
Avi (use Gerrit)
lgtm Fingers crossed.
4 years, 2 months ago (2016-10-17 21:00:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422323002/1
4 years, 2 months ago (2016-10-17 23:22:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 23:28:50 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 23:31:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f38c80506465dbf4db63ad795bd94cc7fdf3673a
Cr-Commit-Position: refs/heads/master@{#425811}

Powered by Google App Engine
This is Rietveld 408576698