Fix Bookmarks Bar Drag-and-Drop between folders

Fix Bookmarks Bar Drag-and-Drop between folders

Currently you cannot drag between two bookmarks folders on Linux and Windows.
Widget destruction on those platforms tears down their platform specific
drag-and-drop implementations.

This change updates MenuController to not tear down when Cancel is called if
a drag is currently occurring. The menu will still have all windows hidden, and
will be destroyed when drag-and-drop completes.

There are interactive_ui_tests covering the integration tests of this feature
in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing
the bug at submission time. I've filed crbug.com/656712 to track the issues
with X11 preventing getting these tests running.

TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows
BUG=636397
Committed: https://crrev.com/24470df35ac9d98824f447d9a0112c0bdbdf1cb5
Cr-Commit-Position: refs/heads/master@{#425790}

[jonross, 2016-10-17 18:14:23]

Patchset #1 (id:1) has been deleted

[jonross, 2016-10-17 18:14:58]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2016-10-17 18:14:59]

sky@ could you take a look at this review? It's an update to menu closing to
address a drag-and-drop bug.

Thanks,
Jon

[sky, 2016-10-17 20:23:17]

LGTM

[jonross, 2016-10-17 20:47:01]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-10-17 20:47:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 22:22:30]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-10-17 22:24:42]

Description was changed from

==========
Fix Bookmarks Bar Drag-and-Drop between folders

Currently you cannot drag between two bookmarks folders on Linux and Windows.
Widget destruction on those platforms tears down their platform specific
drag-and-drop implementations.

This change updates MenuController to not tear down when Cancel is called if
a drag is currently occurring. The menu will still have all windows hidden, and
will be destroyed when drag-and-drop completes.

There are interactive_ui_tests covering the integration tests of this feature
in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing
the bug at submission time. I've filed crbug.com/656712 to track the issues
with X11 preventing getting these tests running.

TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows
BUG=636397
==========

to

==========
Fix Bookmarks Bar Drag-and-Drop between folders

Currently you cannot drag between two bookmarks folders on Linux and Windows.
Widget destruction on those platforms tears down their platform specific
drag-and-drop implementations.

This change updates MenuController to not tear down when Cancel is called if
a drag is currently occurring. The menu will still have all windows hidden, and
will be destroyed when drag-and-drop completes.

There are interactive_ui_tests covering the integration tests of this feature
in BookmarkBarViewTest. However they are disabled on Windows and Linux, missing
the bug at submission time. I've filed crbug.com/656712 to track the issues
with X11 preventing getting these tests running.

TEST=MenuControllerTest.CancelAllDuringDrag, manual testing on Linux and Windows
BUG=636397

Committed: https://crrev.com/24470df35ac9d98824f447d9a0112c0bdbdf1cb5
Cr-Commit-Position: refs/heads/master@{#425790}
==========

[commit-bot: I haz the power, 2016-10-17 22:24:43]

Patchset 1 (id:??) landed as
https://crrev.com/24470df35ac9d98824f447d9a0112c0bdbdf1cb5
Cr-Commit-Position: refs/heads/master@{#425790}