components/sync/engine_impl/attachments/attachment_downloader_impl.cc - Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/attachments/attachment_downloader_impl.cc

Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead. (Closed)

Patch Set: Fixing compile. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync/engine_impl/apply_control_data_updates_unittest.cc ('k') | components/sync/engine_impl/attachments/attachment_downloader_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/engine_impl/attachments/attachment_downloader_impl.cc

diff --git a/components/sync/engine_impl/attachments/attachment_downloader_impl.cc b/components/sync/engine_impl/attachments/attachment_downloader_impl.cc

index 2135d6b20291fdee8b03849735d49173ad5d71a2..7835c2fe1add8e28e95e3bedcc39f0ec6b81a434 100644

--- a/components/sync/engine_impl/attachments/attachment_downloader_impl.cc

+++ b/components/sync/engine_impl/attachments/attachment_downloader_impl.cc

@@ -9,6 +9,7 @@

#include "base/base64.h"

#include "base/bind.h"

#include "base/location.h"

+#include "base/memory/ptr_util.h"

#include "base/metrics/histogram.h"

#include "base/metrics/histogram_macros.h"

#include "base/metrics/sparse_histogram.h"

@@ -239,8 +240,8 @@ void AttachmentDownloaderImpl::ReportResult(

iter != download_state.user_callbacks.end(); ++iter) {

std::unique_ptr<Attachment> attachment;

if (result == DOWNLOAD_SUCCESS) {

- attachment.reset(new Attachment(Attachment::CreateFromParts(

- download_state.attachment_id, attachment_data)));

+ attachment = base::MakeUnique<Attachment>(Attachment::CreateFromParts(

+ download_state.attachment_id, attachment_data));

}

base::ThreadTaskRunnerHandle::Get()->PostTask(