components/sync/device_info/local_device_info_provider_impl_unittest.cc - Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/device_info/local_device_info_provider_impl_unittest.cc

Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead. (Closed)

Patch Set: Fixing compile. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync/device_info/local_device_info_provider_impl.cc ('k') | components/sync/device_info/local_device_info_provider_mock.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/device_info/local_device_info_provider_impl_unittest.cc

diff --git a/components/sync/device_info/local_device_info_provider_impl_unittest.cc b/components/sync/device_info/local_device_info_provider_impl_unittest.cc

index 39a864257fde3414069365f9058de846fc964884..e3fbf77558245850708579e5a8ef5c7e45654b15 100644

--- a/components/sync/device_info/local_device_info_provider_impl_unittest.cc

+++ b/components/sync/device_info/local_device_info_provider_impl_unittest.cc

@@ -5,6 +5,7 @@

#include "components/sync/device_info/local_device_info_provider_impl.h"

#include "base/bind.h"

+#include "base/memory/ptr_util.h"

#include "base/message_loop/message_loop.h"

#include "base/run_loop.h"

#include "components/sync/base/get_session_name.h"

@@ -21,9 +22,9 @@ class LocalDeviceInfoProviderImplTest : public testing::Test {

~LocalDeviceInfoProviderImplTest() override {}

void SetUp() override {

- provider_.reset(new LocalDeviceInfoProviderImpl(

+ provider_ = base::MakeUnique<LocalDeviceInfoProviderImpl>(

version_info::Channel::UNKNOWN,

- version_info::GetVersionStringWithModifier("UNKNOWN"), false));

+ version_info::GetVersionStringWithModifier("UNKNOWN"), false);

}

void TearDown() override {