Reland of Delete pre-MD code from OmniboxResultView

Reland of Delete pre-MD code from OmniboxResultView

Reland of https://codereview.chromium.org/2365263006/ after the
downstream iOS code was fixed to not uses the deleted resources
or methods.

BUG=648281
Committed: https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3
Cr-Commit-Position: refs/heads/master@{#425783}

[sdefresne, 2016-10-17 14:43:24]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 14:43:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-10-17 14:45:05]

sdefresne@chromium.org changed reviewers:
+ pkasting@chromium.org, sky@chromium.org

[sdefresne, 2016-10-17 14:45:05]

Please take a look.

[commit-bot: I haz the power, 2016-10-17 14:56:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 14:56:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-10-17 15:28:51]

LGTM

https://codereview.chromium.org/2422193002/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_context_menu_model.cc (right):

https://codereview.chromium.org/2422193002/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_context_menu_model.cc:333:
gfx::Omage(gfx::CreateVectorIcon(gfx::VectorIconId::BUSINESS, 16,
gfx::Image?

https://codereview.chromium.org/2422193002/diff/1/chrome/browser/ui/views/omn...
File chrome/browser/ui/views/omnibox/omnibox_result_view.h (right):

https://codereview.chromium.org/2422193002/diff/1/chrome/browser/ui/views/omn...
chrome/browser/ui/views/omnibox/omnibox_result_view.h:23: class LocationBarView;
No longer needed?

[Evan Stade, 2016-10-17 15:45:21]

Thank you for this patch and the upstreaming one.

[sdefresne, 2016-10-17 16:22:01]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 16:22:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 16:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 16:34:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sdefresne, 2016-10-17 17:06:29]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 17:06:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 17:54:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 17:54:34]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-10-17 18:58:43]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-10-17 18:58:49]

https://codereview.chromium.org/2422193002/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_context_menu_model.cc (right):

https://codereview.chromium.org/2422193002/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_context_menu_model.cc:333:
gfx::Omage(gfx::CreateVectorIcon(gfx::VectorIconId::BUSINESS, 16,
On 2016/10/17 15:28:51, sky wrote:
> gfx::Image?

Fixed.

https://codereview.chromium.org/2422193002/diff/1/chrome/browser/ui/views/omn...
File chrome/browser/ui/views/omnibox/omnibox_result_view.h (right):

https://codereview.chromium.org/2422193002/diff/1/chrome/browser/ui/views/omn...
chrome/browser/ui/views/omnibox/omnibox_result_view.h:23: class LocationBarView;
On 2016/10/17 15:28:51, sky wrote:
> No longer needed?

Done.

[commit-bot: I haz the power, 2016-10-17 18:59:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2016-10-17 20:46:48]

Is there something that diffs against the originally-landed patch?  Since I OK'd
that one I don't need to re-review unless there's something substantial that's
changed.

[sdefresne, 2016-10-17 20:49:49]

On 2016/10/17 20:46:48, Peter Kasting wrote:
> Is there something that diffs against the originally-landed patch?  Since I
OK'd
> that one I don't need to re-review unless there's something substantial that's
> changed.

No, nothing changed. I however manually applied the patch as git cl patch was
failing due to the binary files.

[Peter Kasting, 2016-10-17 20:56:59]

RS LGTM then.

[commit-bot: I haz the power, 2016-10-17 21:03:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 21:03:23]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-10-17 21:29:59]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-10-17 21:29:59]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2422193002/#ps60001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-10-17 21:30:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 21:37:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-17 21:40:53]

Description was changed from

==========
Reland of Delete pre-MD code from OmniboxResultView

Reland of https://codereview.chromium.org/2365263006/ after the
downstream iOS code was fixed to not uses the deleted resources
or methods.

BUG=648281
==========

to

==========
Reland of Delete pre-MD code from OmniboxResultView

Reland of https://codereview.chromium.org/2365263006/ after the
downstream iOS code was fixed to not uses the deleted resources
or methods.

BUG=648281

Committed: https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3
Cr-Commit-Position: refs/heads/master@{#425783}
==========

[commit-bot: I haz the power, 2016-10-17 21:40:55]

Patchset 4 (id:??) landed as
https://crrev.com/7f0151ac5e3d27fa34aafaef72c14ca9f73fabb3
Cr-Commit-Position: refs/heads/master@{#425783}