Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 2422103006: Revert of [build] Switch off warning on gcc bots. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [build] Switch off warning on gcc bots. (patchset #2 id:20001 of https://codereview.chromium.org/2425913002/ ) Reason for revert: Seems to be the wrong flag: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/4709 Original issue's description: > [build] Switch off warning on gcc bots. > > Switch off maybe-uninitialized warning as it gives often > false positives with optimizations in gcc. > > NOTRY=true > TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org > > Committed: https://crrev.com/0ef0d5b2b8cffd1e3647d79c5ba19752bbbc469c > Cr-Commit-Position: refs/heads/master@{#40382} TBR=bmeurer@chromium.org,zhengxing.li@intel.com,caitp@igalia.com,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/179436cf8cc414fb6c1921ab45823e7165f15fc5 Cr-Commit-Position: refs/heads/master@{#40385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M gypfiles/standalone.gypi View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [build] Switch off warning on gcc bots.
4 years, 2 months ago (2016-10-18 08:02:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422103006/1
4 years, 2 months ago (2016-10-18 08:02:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 08:03:00 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 08:03:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/179436cf8cc414fb6c1921ab45823e7165f15fc5
Cr-Commit-Position: refs/heads/master@{#40385}

Powered by Google App Engine
This is Rietveld 408576698