Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: ui/display/display_list.cc

Issue 2422073002: Reduce FOR_EACH_OBSERVER usage in ui/ (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/display/display_list.cc
diff --git a/ui/display/display_list.cc b/ui/display/display_list.cc
index 842808a8a5cbace57a7e753067c9b49f6a632abd..bd963ad3dd32fc006fefbea1ebc725eb6f97a92d 100644
--- a/ui/display/display_list.cc
+++ b/ui/display/display_list.cc
@@ -92,8 +92,8 @@ void DisplayList::UpdateDisplay(const display::Display& display, Type type) {
display::DisplayObserver::DISPLAY_METRIC_DEVICE_SCALE_FACTOR;
}
if (should_notify_observers()) {
- FOR_EACH_OBSERVER(display::DisplayObserver, observers_,
- OnDisplayMetricsChanged(*local_display, changed_values));
+ for (auto& observer : observers_)
+ observer.OnDisplayMetricsChanged(*local_display, changed_values);
}
}
@@ -103,8 +103,8 @@ void DisplayList::AddDisplay(const display::Display& display, Type type) {
if (type == Type::PRIMARY)
primary_display_index_ = static_cast<int>(displays_.size()) - 1;
if (should_notify_observers()) {
- FOR_EACH_OBSERVER(display::DisplayObserver, observers_,
- OnDisplayAdded(display));
+ for (auto& observer : observers_)
+ observer.OnDisplayAdded(display);
}
}
@@ -123,8 +123,8 @@ void DisplayList::RemoveDisplay(int64_t id) {
const display::Display display = *iter;
displays_.erase(iter);
if (should_notify_observers()) {
- FOR_EACH_OBSERVER(display::DisplayObserver, observers_,
- OnDisplayRemoved(display));
+ for (auto& observer : observers_)
+ observer.OnDisplayRemoved(display);
}
}

Powered by Google App Engine
This is Rietveld 408576698