Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: platform_tools/android/bin/gyp_to_android.py

Issue 242203008: Allow running gyp_to_android without SkUserConfig. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: copyfileobj, tests, gyp_to_android executable. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | platform_tools/android/gyp_gen/generate_user_config.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/bin/gyp_to_android.py
diff --git a/platform_tools/android/bin/gyp_to_android.py b/platform_tools/android/bin/gyp_to_android.py
old mode 100644
new mode 100755
index c8abfb60fdc8f1167fd3edbbdc17da141ffcecd5..f7199b8ddb68e5b9778d5f4057ce2d9766f26e29
--- a/platform_tools/android/bin/gyp_to_android.py
+++ b/platform_tools/android/bin/gyp_to_android.py
@@ -64,12 +64,14 @@ def generate_var_dict(target_dir, target_file, skia_arch_type, have_neon):
print '.',
return var_dict
-def main(target_dir=None):
+def main(target_dir=None, require_sk_user_config=False):
"""
Read gyp files and create Android.mk for the Android framework's
external/skia.
@param target_dir Directory in which to place 'Android.mk'. If None, the file
will be placed in skia's root directory.
+ @param require_sk_user_config If True, raise an AssertionError if
+ SkUserConfig.h does not exist.
"""
# Create a temporary folder to hold gyp and gypd files. Create it in SKIA_DIR
# so that it is a sibling of gyp/, so the relationships between gyp files and
@@ -125,7 +127,8 @@ def main(target_dir=None):
dst_dir = os.path.join(SKIA_DIR, 'include', 'core')
generate_user_config.generate_user_config(
- original_sk_user_config=user_config, target_dir=dst_dir,
+ original_sk_user_config=user_config,
+ require_sk_user_config=require_sk_user_config, target_dir=dst_dir,
ordered_set=common.DEFINES)
# Now that the defines have been written to SkUserConfig, they are not
« no previous file with comments | « no previous file | platform_tools/android/gyp_gen/generate_user_config.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698