Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 242203006: Revert 264763 "Wire up codec_delay() to MP3StreamParser and FFmp..." (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 264763 "Wire up codec_delay() to MP3StreamParser and FFmp..." Possible candidate for broken media_unittests: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30043/steps/media_unittests/logs/MediaSource_MP3_TimestampOffset_0 > Wire up codec_delay() to MP3StreamParser and FFmpegAudioDecoder. > > Allows us to drop silent samples from the decoder after initialization > and resets. > > codec_delay() is always in frames, so I've changed all call sites to use > frames instead of a TimeDelta. > > Coincidentally also fixes an issue where not enough data was dropped from > Vorbis buffers with negative timestamps. > > BUG=360961 > TEST=new pipeline_integration_test > > Review URL: https://codereview.chromium.org/239423005 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -96 lines) Patch
M trunk/src/media/base/audio_decoder_config.h View 3 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/media/base/audio_decoder_config.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/media/ffmpeg/ffmpeg_common.cc View 2 chunks +7 lines, -1 line 0 comments Download
M trunk/src/media/filters/decrypting_audio_decoder_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/filters/decrypting_demuxer_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/filters/ffmpeg_audio_decoder.cc View 4 chunks +23 lines, -21 lines 0 comments Download
M trunk/src/media/filters/opus_audio_decoder.h View 1 chunk +8 lines, -2 lines 0 comments Download
M trunk/src/media/filters/opus_audio_decoder.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M trunk/src/media/filters/pipeline_integration_test.cc View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/media/formats/mp4/mp4_stream_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/formats/mpeg/adts_stream_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/formats/mpeg/mp3_stream_parser.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/media/formats/mpeg/mp3_stream_parser_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/media/formats/mpeg/mpeg_audio_stream_parser_base.h View 2 chunks +1 line, -6 lines 0 comments Download
M trunk/src/media/formats/mpeg/mpeg_audio_stream_parser_base.cc View 2 chunks +5 lines, -14 lines 0 comments Download
M trunk/src/media/formats/webm/webm_audio_client.cc View 1 chunk +3 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ken Rockot(use gerrit already)
6 years, 8 months ago (2014-04-18 16:12:57 UTC) #1
Ken Rockot(use gerrit already)
Committed patchset #1 manually as r264803.
6 years, 8 months ago (2014-04-18 16:13:21 UTC) #2
DaleCurtis
6 years, 8 months ago (2014-04-18 19:58:55 UTC) #3
Message was sent while issue was closed.
This was not the cause of the issue, reverted here:
https://src.chromium.org/viewvc/chrome?view=rev&revision=264834

Fix for the issue under review here:

https://codereview.chromium.org/240123004/

Powered by Google App Engine
This is Rietveld 408576698