Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 242203003: [New Multicolumn] Make floats affect heights correctly. (Closed)

Created:
6 years, 8 months ago by mstensho (USE GERRIT)
Modified:
6 years, 8 months ago
Reviewers:
ojan
CC:
blink-reviews, mstensho+blink_opera.com, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[New Multicolumn] Make floats affect heights correctly. Don't let overhanging floats bleed into sibling column sets or into the parent block flow. Let RenderFlowThread establish a new block formatting context, so that its height encompasses all descendant floats. BUG=361551 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171996

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -10 lines) Patch
A LayoutTests/fast/multicol/tall-float1.html View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/tall-float1-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A + LayoutTests/fast/multicol/tall-float2.html View 1 chunk +5 lines, -4 lines 0 comments Download
A + LayoutTests/fast/multicol/tall-float2-expected.html View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mstensho (USE GERRIT)
6 years, 8 months ago (2014-04-18 08:46:12 UTC) #1
ojan
lgtm https://codereview.chromium.org/242203003/diff/1/LayoutTests/fast/multicol/tall-float1.html File LayoutTests/fast/multicol/tall-float1.html (right): https://codereview.chromium.org/242203003/diff/1/LayoutTests/fast/multicol/tall-float1.html#newcode2 LayoutTests/fast/multicol/tall-float1.html:2: <html> Nit: You can leave out the html, ...
6 years, 8 months ago (2014-04-19 02:05:38 UTC) #2
ojan
The CQ bit was unchecked by ojan@chromium.org
6 years, 8 months ago (2014-04-19 02:05:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/242203003/1
6 years, 8 months ago (2014-04-19 02:05:43 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-19 02:05:49 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/rendering/RenderBlockFlow.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-19 02:05:50 UTC) #6
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 8 months ago (2014-04-19 08:52:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/242203003/20001
6 years, 8 months ago (2014-04-19 08:52:32 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-19 10:11:23 UTC) #9
Message was sent while issue was closed. 
Change committed as 171996

Powered by Google App Engine
This is Rietveld 408576698