Issue 242203002: Don't garbage collect storage for disabled and crashed extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 242203002: Don't garbage collect storage for disabled and crashed extensions. (Closed)

Created:
6 years, 8 months ago by Marijn Kruisselbrink

Modified:
6 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't garbage collect storage for disabled and crashed extensions. BUG=328637

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/extensions/extension_garbage_collector.cc	View		1 chunk	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Marijn Kruisselbrink

I really don't know this code, but since you're the original author of it maybe ...

6 years, 8 months ago (2014-04-17 23:25:49 UTC) #1

awong

6 years, 8 months ago (2014-04-21 17:54:18 UTC) #2

From a mechanics perspective, it looks sensible to me. However, I really don't
understand the extensions subsystem and the policy that you're targeting.

It looks like this change will avoid deleting the storage for all "installed,
disabled, blacklisted, and terminated extensions."
 
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/browser...

Is that the desired behavior? Who's the right person to sanity check the target
policy for cleanup?

https://codereview.chromium.org/242203002/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_garbage_collector.cc (right):

https://codereview.chromium.org/242203002/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_garbage_collector.cc:224:
ExtensionRegistry::Get(context_)->GenerateInstalledExtensionsSet();
Can you update the comment in the .h file to match the new filter criteria?

Expand Messages | Collapse Messages