Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2421983002: [DevTools] Remove layout editor experiment. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove layout editor experiment. BUG=none Committed: https://crrev.com/5b57fb0aacb2c52a1fc77e1a2865bac9fa0e0330 Cr-Commit-Position: refs/heads/master@{#436082}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -1800 lines) Patch
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 2 chunks +28 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorOverlayHost.h View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorOverlayHost.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorOverlayHost.idl View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorOverlayPage.html View 6 chunks +1 line, -805 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/LayoutEditor.h View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/LayoutEditor.cpp View 1 1 chunk +0 lines, -438 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js View 1 5 chunks +0 lines, -44 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/elements/PropertyChangeHighlighter.js View 1 1 chunk +0 lines, -144 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/elements/StylePropertyHighlighter.js View 1 1 chunk +51 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 chunks +1 line, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/module.json View 1 2 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js View 1 3 chunks +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 1 6 chunks +1 line, -15 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 10 chunks +3 lines, -93 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
dgozman
FYI :-)
4 years, 2 months ago (2016-10-17 19:26:21 UTC) #6
dgozman
Please take a look.
4 years ago (2016-12-02 02:29:00 UTC) #8
pfeldman
lgtm
4 years ago (2016-12-02 21:31:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421983002/20001
4 years ago (2016-12-02 22:13:13 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 23:49:29 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-02 23:51:27 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b57fb0aacb2c52a1fc77e1a2865bac9fa0e0330
Cr-Commit-Position: refs/heads/master@{#436082}

Powered by Google App Engine
This is Rietveld 408576698