Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3345)

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h

Issue 2421943002: Make JavaScript dialogs auto-dismiss on tab switch. (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h
diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h b/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h
new file mode 100644
index 0000000000000000000000000000000000000000..79abf3302f28e12b13471a04e6ad92f15901fac9
--- /dev/null
+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h
@@ -0,0 +1,75 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_VIEWS_H_
+#define CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_VIEWS_H_
+
+#include <memory>
+
+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "content/public/browser/javascript_dialog_manager.h"
+#include "ui/views/window/dialog_delegate.h"
+
+namespace views {
+class MessageBoxView;
+}
+
+class JavaScriptDialogViews : public views::DialogDelegate {
Peter Kasting 2016/10/17 20:16:05 Nit: Add description of what this class is and why
Avi (use Gerrit) 2016/10/18 02:46:42 Done.
+ public:
+ static base::WeakPtr<JavaScriptDialogViews> Create(
Peter Kasting 2016/10/17 20:16:05 Nit: Per https://google.github.io/styleguide/cppgu
Avi (use Gerrit) 2016/10/18 02:46:42 Done.
+ content::WebContents* parent_web_contents,
+ content::WebContents* alerting_web_contents,
+ const base::string16& title,
+ content::JavaScriptMessageType message_type,
+ const base::string16& message_text,
+ const base::string16& default_prompt_text,
+ const content::JavaScriptDialogManager::DialogClosedCallback&
+ dialog_callback);
+ ~JavaScriptDialogViews() override;
+
+ void CloseJavaScriptDialog();
+
+ // views::DialogDelegate:
+ int GetDefaultDialogButton() const override;
+ int GetDialogButtons() const override;
+ base::string16 GetWindowTitle() const override;
+ bool Cancel() override;
+ bool Accept() override;
+ bool Close() override;
+ void DeleteDelegate() override;
+
+ // views::WidgetDelegate:
+ views::View* GetContentsView() override;
+ views::View* GetInitiallyFocusedView() override;
+ views::Widget* GetWidget() override;
+ const views::Widget* GetWidget() const override;
+ ui::ModalType GetModalType() const override;
+
+ private:
+ JavaScriptDialogViews(
+ content::WebContents* parent_web_contents,
+ content::WebContents* alerting_web_contents,
+ const base::string16& title,
+ content::JavaScriptMessageType message_type,
+ const base::string16& message_text,
+ const base::string16& default_prompt_text,
+ const content::JavaScriptDialogManager::DialogClosedCallback&
+ dialog_callback);
+
+ base::string16 title_;
+ content::JavaScriptMessageType message_type_;
+ base::string16 message_text_;
+ base::string16 default_prompt_text_;
+ content::JavaScriptDialogManager::DialogClosedCallback dialog_callback_;
+
+ // The message box view whose commands we handle.
+ views::MessageBoxView* message_box_view_;
+
+ base::WeakPtrFactory<JavaScriptDialogViews> weak_factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(JavaScriptDialogViews);
+};
+
+#endif // CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_VIEWS_H_

Powered by Google App Engine
This is Rietveld 408576698