Make JavaScript dialogs auto-dismiss on tab switch.

chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h

Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h
diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h b/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h
new file mode 100644
index 0000000000000000000000000000000000000000..fc5b1ba48897872069a496220e088f81948e42b0
--- /dev/null
+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h
@@ -0,0 +1,80 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_VIEWS_H_
+#define CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_VIEWS_H_
+
+#include <memory>
+
+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "content/public/browser/javascript_dialog_manager.h"
+#include "ui/views/window/dialog_delegate.h"
+
+namespace views {
+class MessageBoxView;
+}
+
+// A Views version of a JavaScript dialog that automatically dismisses itself
+// when the user switches away from interacting with the tab, used for

[Peter Kasting, 2016/10/18 16:59:55]

Nit: switches away from interacting with the tab -> switches tabs?  (I'm just
worried that the "from interacting with" part sounds like maybe if I change to
interacting with the omnibox or something, I've stopped interacting with the
tab, so the dialog should dismiss.)

[Avi (use Gerrit), 2016/10/18 17:06:07]

Done.

+// WebContentses that are browser tabs.
+class JavaScriptDialogViews : public views::DialogDelegate {
+ public:
+  ~JavaScriptDialogViews() override;
+
+  static base::WeakPtr<JavaScriptDialogViews> Create(
+      content::WebContents* parent_web_contents,
+      content::WebContents* alerting_web_contents,
+      const base::string16& title,
+      content::JavaScriptMessageType message_type,
+      const base::string16& message_text,
+      const base::string16& default_prompt_text,
+      const content::JavaScriptDialogManager::DialogClosedCallback&
+          dialog_callback);
+
+  // Closes the dialog without sending a callback.
+  void CloseJavaScriptDialog();
+
+  // views::DialogDelegate:
+  int GetDefaultDialogButton() const override;
+  int GetDialogButtons() const override;
+  base::string16 GetWindowTitle() const override;
+  bool Cancel() override;
+  bool Accept() override;
+  bool Close() override;
+  void DeleteDelegate() override;
+
+  // views::WidgetDelegate:
+  views::View* GetContentsView() override;
+  views::View* GetInitiallyFocusedView() override;
+  views::Widget* GetWidget() override;
+  const views::Widget* GetWidget() const override;
+  ui::ModalType GetModalType() const override;
+
+ private:
+  JavaScriptDialogViews(
+      content::WebContents* parent_web_contents,
+      content::WebContents* alerting_web_contents,
+      const base::string16& title,
+      content::JavaScriptMessageType message_type,
+      const base::string16& message_text,
+      const base::string16& default_prompt_text,
+      const content::JavaScriptDialogManager::DialogClosedCallback&
+          dialog_callback);
+
+  base::string16 title_;
+  content::JavaScriptMessageType message_type_;
+  base::string16 message_text_;
+  base::string16 default_prompt_text_;
+  content::JavaScriptDialogManager::DialogClosedCallback dialog_callback_;
+
+  // The message box view whose commands we handle.
+  views::MessageBoxView* message_box_view_;
+
+  base::WeakPtrFactory<JavaScriptDialogViews> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(JavaScriptDialogViews);
+};
+
+#endif  // CHROME_BROWSER_UI_JAVASCRIPT_DIALOGS_JAVASCRIPT_DIALOG_VIEWS_H_