Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 2421923002: [turbofan] Inline Object.prototype.__proto__ getter. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Inline Object.prototype.__proto__ getter. In the JSCallReducer, recognize and inline calls to the __proto__ getter on the %ObjectPrototype%. R=yangguo@chromium.org BUG=chromium:655963 Committed: https://crrev.com/0f4a4ae026944d6932f4cd590c78072f72d5f7ce Cr-Commit-Position: refs/heads/master@{#40335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -14 lines) Patch
M src/compiler/js-call-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 2 chunks +59 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-14 18:14:00 UTC) #1
Benedikt Meurer
Hey Yang, Here's the follow-up TurboFan version of __proto__ getter for the common case, i.e. ...
4 years, 2 months ago (2016-10-14 18:18:51 UTC) #4
Yang
On 2016/10/14 18:18:51, Benedikt Meurer wrote: > Hey Yang, > > Here's the follow-up TurboFan ...
4 years, 2 months ago (2016-10-17 05:40:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421923002/1
4 years, 2 months ago (2016-10-17 05:40:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 06:28:41 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 06:29:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f4a4ae026944d6932f4cd590c78072f72d5f7ce
Cr-Commit-Position: refs/heads/master@{#40335}

Powered by Google App Engine
This is Rietveld 408576698