Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js

Issue 2421913003: DevTools: allow reattaching main target live. (Closed)
Patch Set: review comments addressed. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js b/third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js
index 16c032a9321862ffd11905b3ccca0607d9c0b71f..5162b68fdf1cd1bb868db06a9fb0ca6cf010869e 100644
--- a/third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js
@@ -79,7 +79,7 @@ WebInspector.RemoteLocationManager.prototype = {
var target = this._connectedTargets.get(targetId);
this._connectedTargets.delete(targetId);
if (target)
- WebInspector.targetManager.removeTarget(target);
+ target.dispose();
}
}
@@ -140,9 +140,12 @@ WebInspector.RemoteLocationConnection.prototype = {
this._agent.sendMessage(this._targetId, JSON.stringify(messageObject));
},
- _close: function()
+ /**
+ * @override
+ */
+ forceClose: function()
{
- this.connectionClosed("node_detached");
+ this._agent.detach(this._targetId, () => {});
},
__proto__: InspectorBackendClass.Connection.prototype

Powered by Google App Engine
This is Rietveld 408576698