third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js - Issue 2421913003: DevTools: allow reattaching main target live.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js

Issue 2421913003: DevTools: allow reattaching main target live. (Closed)

Patch Set: same Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js ('K') | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/main/module.json » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/Connections.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js b/third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js

index 16c032a9321862ffd11905b3ccca0607d9c0b71f..1f3ccfc622e023b717af8eefb64a3304ab196b18 100644

--- a/third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/main/RemoteLocationManager.js

@@ -140,9 +140,9 @@ WebInspector.RemoteLocationConnection.prototype = {

this._agent.sendMessage(this._targetId, JSON.stringify(messageObject));

- _close: function()

+ forceClose: function()

dgozman 2016/10/15 00:26:26 @override

{

- this.connectionClosed("node_detached");

+ this._agent.detach(this._targetId, ()=>{});

dgozman 2016/10/15 00:26:26 () => {}

__proto__: InspectorBackendClass.Connection.prototype