Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4377)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2421913003: DevTools: allow reattaching main target live. (Closed)
Patch Set: same Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | third_party/WebKit/Source/devtools/BUILD.gn » ('j') | third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index 2c5a4e70bf09c1f502dc015ac8519b29a3ac8801..404b9e5bdeff46c23ed9fe03fb4ad5a4fae76b6b 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -946,8 +946,7 @@ WebContents* DevToolsWindow::OpenURLFromTab(
inspected_web_contents->OpenURL(params) : NULL;
}
- bindings_->Reattach();
-
+ bindings_->Reload();
content::NavigationController::LoadURLParams load_url_params(params.url);
main_web_contents_->GetController().LoadURLWithParams(load_url_params);
dgozman 2016/10/15 00:26:26 Remove.
return main_web_contents_;
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | third_party/WebKit/Source/devtools/BUILD.gn » ('j') | third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698