Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2421893002: Fix hermetic argument to run_verify_order. (Closed)

Created:
4 years, 2 months ago by justincohen
Modified:
4 years, 2 months ago
Reviewers:
erikchen, Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix hermetic argument to run_verify_order. s/developer-dir/developer_dir. BUG=651267 Committed: https://crrev.com/e4292073dac379dba1f418b78497397a484f43bc Cr-Commit-Position: refs/heads/master@{#425414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
justincohen
ptal
4 years, 2 months ago (2016-10-14 17:36:26 UTC) #3
Nico
rs lgtm
4 years, 2 months ago (2016-10-14 17:46:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421893002/1
4 years, 2 months ago (2016-10-14 17:47:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 19:07:42 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 19:11:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4292073dac379dba1f418b78497397a484f43bc
Cr-Commit-Position: refs/heads/master@{#425414}

Powered by Google App Engine
This is Rietveld 408576698