Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2421883002: [ic] Support data handlers that represent loads of constants from prototypes. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Support data handlers that represent loads of constants from prototypes. BUG= Committed: https://crrev.com/5acc31d86329794407f2764a369c2f638305b376 Cr-Commit-Position: refs/heads/master@{#40325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -25 lines) Patch
M src/counters.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ic.h View 1 chunk +12 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 3 chunks +34 lines, -22 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-10-14 15:17:12 UTC) #4
Jakob Kummerow
lgtm
4 years, 2 months ago (2016-10-14 19:20:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421883002/1
4 years, 2 months ago (2016-10-14 19:20:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 19:24:38 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 19:25:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5acc31d86329794407f2764a369c2f638305b376
Cr-Commit-Position: refs/heads/master@{#40325}

Powered by Google App Engine
This is Rietveld 408576698