Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2421863002: Clean up SVGViewSpec::parseViewSpecInternal (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up SVGViewSpec::parseViewSpecInternal Make this function slightly more readable by partitioning it as: 1) Parse outer function ("svgView") 2) For all functions: 2.1) Match/parse "function name" 2.2) Parse arguments to said function This gets rid of a lot of the parameter list boilerplate that every case shares. (I.e handling '(' and ')'.) Also change to use skipExactly and skipUntil from ParsingUtilities.h. Committed: https://crrev.com/6213989c3e5b0295a6324dd9de3c600512deda04 Cr-Commit-Position: refs/heads/master@{#425315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -59 lines) Patch
M third_party/WebKit/Source/core/svg/SVGViewSpec.cpp View 2 chunks +76 lines, -59 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fs
4 years, 2 months ago (2016-10-14 13:45:40 UTC) #6
Stephen Chennney
Makes it a lot more readable. LGTM.
4 years, 2 months ago (2016-10-14 14:08:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421863002/1
4 years, 2 months ago (2016-10-14 14:13:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 14:19:04 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 14:21:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6213989c3e5b0295a6324dd9de3c600512deda04
Cr-Commit-Position: refs/heads/master@{#425315}

Powered by Google App Engine
This is Rietveld 408576698