Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2421853003: Remove usage of FOR_EACH_OBSERVER macro in ash/ (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews, mlamouri+watch-screen-orientation_chromium.org, kalyank, posciak+watch_chromium.org, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in ash/ Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33 Cr-Commit-Position: refs/heads/master@{#425741}

Patch Set 1 #

Patch Set 2 : shell_observers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -72 lines) Patch
M ash/aura/wm_shell_aura.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M ash/common/keyboard/keyboard_ui.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_manager.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/display/screen_orientation_controller_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/window_tree_host_manager.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M ash/first_run/first_run_helper_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.cc View 5 chunks +28 lines, -25 lines 0 comments Download
M ash/mus/keyboard_ui_mus.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/mus/window_manager.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download
M ash/shell.cc View 1 5 chunks +14 lines, -14 lines 0 comments Download
M ash/wm/video_detector.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 22:01:17 UTC) #10
sky
Please spread the load sky->oshima
4 years, 2 months ago (2016-10-17 15:42:19 UTC) #12
oshima
lgtm
4 years, 2 months ago (2016-10-17 17:11:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421853003/20001
4 years, 2 months ago (2016-10-17 18:45:08 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-17 19:19:39 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 19:25:17 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5eff47d40c77f3b32269da49e144fe4836429a33
Cr-Commit-Position: refs/heads/master@{#425741}

Powered by Google App Engine
This is Rietveld 408576698