Move layout tree reconstruction code for Text nodes into new function

third_party/WebKit/Source/core/dom/Text.cpp

Index: third_party/WebKit/Source/core/dom/Text.cpp
diff --git a/third_party/WebKit/Source/core/dom/Text.cpp b/third_party/WebKit/Source/core/dom/Text.cpp
index 4017f379c8cca22e0fe45e387d703b258ae3d24a..9ee07ff1f4d70c954a0550064d3eab36acb6af5c 100644
--- a/third_party/WebKit/Source/core/dom/Text.cpp
+++ b/third_party/WebKit/Source/core/dom/Text.cpp
@@ -396,7 +396,17 @@ void Text::recalcTextStyle(StyleRecalcChange change, Text* nextTextSibling) {
     if (needsStyleRecalc())
       layoutItem.setText(dataImpl());
     clearNeedsStyleRecalc();
-  } else if (needsStyleRecalc() || needsWhitespaceLayoutObject()) {
+  } else {
+    if (needsStyleRecalc()) {
+      setNeedsReattachLayoutTree();

[Bugs Nash, 2016/10/17 02:20:52]

probably don't need to implement this yet, not needed until 'The Reorg'

[nainar, 2016/10/17 16:57:31]

The flag setting is being done in the mirror patch here:
https://codereview.chromium.org/2398293003 and so should be done here. The next
patch (the reorg one) doesn't introduce the setting of the bits it just makes
sure that they are being set in the correct phases (style recalc and layout tree
construction).

+      clearNeedsStyleRecalc();

[Bugs Nash, 2016/10/17 02:20:52]

why is this being changed in this patch?

+    }
+    rebuildTextLayoutTree(nextTextSibling);
+  }
+}
+
+void Text::rebuildTextLayoutTree(Text* nextTextSibling) {
+  if (needsReattachLayoutTree() || needsWhitespaceLayoutObject()) {

[Bugs Nash, 2016/10/17 02:20:52]

this check doesn't belong in here, the method shouldn't be called if this
doesn't evaluate to true. you can change it to a DCHECK if you like, but leave
the 'if (needsStyleRecalc() || needsWhitespaceLayoutObject())' check in the
calling method

[nainar, 2016/10/17 16:57:31]

Seems like I misread your comment in the previous patch. Your comment intended
for this:

void Text::recalcTextStyle(StyleRecalcChange change, Text* nextTextSibling) {
  ...
  } else if (needsStyleRecalc() || needsWhitespaceLayoutObject()) {
    setNeedsReattachLayoutTree();
    rebuildTextLayoutTree(nextTextSibling);
  }
}

void Text::rebuildTextLayoutTree(Text* nextTextSibling) {
  reattachLayoutTree();
  if (this->layoutObject())
    reattachWhitespaceSiblingsIfNeeded(nextTextSibling);
  clearNeedsReattachLayoutTree();
}

Implemented this. Let me know if I still seem to be misunderstanding you. 

     reattachLayoutTree();
     if (this->layoutObject())
       reattachWhitespaceSiblingsIfNeeded(nextTextSibling);