Move layout tree reconstruction code for Text nodes into new function

third_party/WebKit/Source/core/dom/Text.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
  * reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 379 matching lines @@
 }
 
 void Text::recalcTextStyle(StyleRecalcChange change, Text* nextTextSibling) {
   if (LayoutTextItem layoutItem = LayoutTextItem(this->layoutObject())) {
     if (change != NoChange || needsStyleRecalc())
       layoutItem.setStyle(document().ensureStyleResolver().styleForText(this));
     if (needsStyleRecalc())
       layoutItem.setText(dataImpl());
     clearNeedsStyleRecalc();
   } else if (needsStyleRecalc() || needsWhitespaceLayoutObject()) {
-    reattachLayoutTree();
-    if (this->layoutObject())
-      reattachWhitespaceSiblingsIfNeeded(nextTextSibling);
-    clearNeedsReattachLayoutTree();
+    setNeedsReattachLayoutTree();

[Bugs Nash, 2016/10/18 23:19:14]

I understand that you want to set flags correctly, but I don't see this as
setting the flag correctly. This sets a flag that is never checked, then calls a
method that clears the flag. I wouldn't include it until it is used.

[nainar, 2016/10/26 05:08:55]

Yup I understand. Made the change. 

+    rebuildTextLayoutTree(nextTextSibling);
   }
 }
 
+void Text::rebuildTextLayoutTree(Text* nextTextSibling) {

[Bugs Nash, 2016/10/18 23:19:14]

yup this is (y)

[nainar, 2016/10/26 05:08:55]

Yeah!

+  reattachLayoutTree();
+  if (this->layoutObject())
+    reattachWhitespaceSiblingsIfNeeded(nextTextSibling);
+  clearNeedsReattachLayoutTree();
+}
+
 // If a whitespace node had no layoutObject and goes through a recalcStyle it
 // may need to create one if the parent style now has white-space: pre.
 bool Text::needsWhitespaceLayoutObject() {
   DCHECK(!layoutObject());
   if (const ComputedStyle* style = parentComputedStyle())
     return style->preserveNewline();
   return false;
 }
 
 // Passing both |textNode| and its layout object because repeated calls to
@@ skipping 29 matching lines @@
 
 Text* Text::cloneWithData(const String& data) {
   return create(document(), data);
 }
 
 DEFINE_TRACE(Text) {
   CharacterData::trace(visitor);
 }
 
 }  // namespace blink