Move layout tree reconstruction code for Text nodes into new function

third_party/WebKit/Source/core/dom/Text.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
  * reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 378 matching lines @@
   CharacterData::attachLayoutTree(reattachContext);
 }
 
 void Text::recalcTextStyle(StyleRecalcChange change, Text* nextTextSibling) {
   if (LayoutTextItem layoutItem = LayoutTextItem(this->layoutObject())) {
     if (change != NoChange || needsStyleRecalc())
       layoutItem.setStyle(document().ensureStyleResolver().styleForText(this));
     if (needsStyleRecalc())
       layoutItem.setText(dataImpl());
     clearNeedsStyleRecalc();
-  } else if (needsStyleRecalc() || needsWhitespaceLayoutObject()) {
+  } else {
+    rebuildTextLayoutTree(nextTextSibling);
+  }
+}
+
+void Text::rebuildTextLayoutTree(Text* nextTextSibling) {
+  if (needsStyleRecalc() || needsWhitespaceLayoutObject()) {

[Bugs Nash, 2016/10/14 03:58:18]

needsStyleRecalc() probably shouldn't be inside this method, as it's supposed to
be about layout. Might need some refactoring and use the new needsLayout flags?

     reattachLayoutTree();
     if (this->layoutObject())
       reattachWhitespaceSiblingsIfNeeded(nextTextSibling);
     clearNeedsReattachLayoutTree();
   }
 }
 
 // If a whitespace node had no layoutObject and goes through a recalcStyle it
 // may need to create one if the parent style now has white-space: pre.
 bool Text::needsWhitespaceLayoutObject() {
@@ skipping 36 matching lines @@
 
 Text* Text::cloneWithData(const String& data) {
   return create(document(), data);
 }
 
 DEFINE_TRACE(Text) {
   CharacterData::trace(visitor);
 }
 
 }  // namespace blink