Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7251)

Unified Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2421753002: MD Settings: Eliminate Relaunch button flicker at chrome://md-settings/help. (Closed)
Patch Set: Fix test. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/about_page/about_page.js
diff --git a/chrome/browser/resources/settings/about_page/about_page.js b/chrome/browser/resources/settings/about_page/about_page.js
index dc61dbb1f5cc056455c123503d309d6fad3174e5..10df3b620bf359afbec9d255ee6098c33dcb2185 100644
--- a/chrome/browser/resources/settings/about_page/about_page.js
+++ b/chrome/browser/resources/settings/about_page/about_page.js
@@ -12,8 +12,22 @@ Polymer({
behaviors: [WebUIListenerBehavior, MainPageBehavior, I18nBehavior],
properties: {
+ /** @private {!{obsolete: boolean, endOfLine: boolean}} */
+ obsoleteSystemInfo_: {
+ type: Object,
+ value: function() {
+ return {
+ obsolete: loadTimeData.getBoolean('aboutObsoleteNowOrSoon'),
+ endOfLine: loadTimeData.getBoolean('aboutObsoleteEndOfTheLine'),
+ };
+ },
+ },
Dan Beam 2016/10/27 19:28:24 i really think we should fix whatever made you mov
dpapad 2016/11/01 00:47:18 Done. Fixed the polymer properties dependencies an
+
/** @private {?UpdateStatusChangedEvent} */
- currentUpdateStatusEvent_: Object,
+ currentUpdateStatusEvent_: {
+ type: Object,
+ value: {message: '', progress: 0, status: UpdateStatus.DISABLED},
+ },
<if expr="chromeos">
/** @private */
@@ -28,17 +42,6 @@ Polymer({
/** @private {?RegulatoryInfo} */
regulatoryInfo_: Object,
</if>
-
- /** @private {!{obsolete: boolean, endOfLine: boolean}} */
- obsoleteSystemInfo_: {
- type: Object,
- value: function() {
- return {
- obsolete: loadTimeData.getBoolean('aboutObsoleteNowOrSoon'),
- endOfLine: loadTimeData.getBoolean('aboutObsoleteEndOfTheLine'),
- };
- },
- },
},
/** @private {?settings.AboutPageBrowserProxy} */
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698