Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Side by Side Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2421753002: MD Settings: Eliminate Relaunch button flicker at chrome://md-settings/help. (Closed)
Patch Set: Fix test. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-about-page' contains version and OS related 6 * @fileoverview 'settings-about-page' contains version and OS related
7 * information. 7 * information.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-about-page', 10 is: 'settings-about-page',
11 11
12 behaviors: [WebUIListenerBehavior, MainPageBehavior, I18nBehavior], 12 behaviors: [WebUIListenerBehavior, MainPageBehavior, I18nBehavior],
13 13
14 properties: { 14 properties: {
15 /** @private {!{obsolete: boolean, endOfLine: boolean}} */
16 obsoleteSystemInfo_: {
17 type: Object,
18 value: function() {
19 return {
20 obsolete: loadTimeData.getBoolean('aboutObsoleteNowOrSoon'),
21 endOfLine: loadTimeData.getBoolean('aboutObsoleteEndOfTheLine'),
22 };
23 },
24 },
Dan Beam 2016/10/27 19:28:24 i really think we should fix whatever made you mov
dpapad 2016/11/01 00:47:18 Done. Fixed the polymer properties dependencies an
25
15 /** @private {?UpdateStatusChangedEvent} */ 26 /** @private {?UpdateStatusChangedEvent} */
16 currentUpdateStatusEvent_: Object, 27 currentUpdateStatusEvent_: {
28 type: Object,
29 value: {message: '', progress: 0, status: UpdateStatus.DISABLED},
30 },
17 31
18 <if expr="chromeos"> 32 <if expr="chromeos">
19 /** @private */ 33 /** @private */
20 hasCheckedForUpdates_: Boolean, 34 hasCheckedForUpdates_: Boolean,
21 35
22 /** @private {!BrowserChannel} */ 36 /** @private {!BrowserChannel} */
23 currentChannel_: String, 37 currentChannel_: String,
24 38
25 /** @private {!BrowserChannel} */ 39 /** @private {!BrowserChannel} */
26 targetChannel_: String, 40 targetChannel_: String,
27 41
28 /** @private {?RegulatoryInfo} */ 42 /** @private {?RegulatoryInfo} */
29 regulatoryInfo_: Object, 43 regulatoryInfo_: Object,
30 </if> 44 </if>
31
32 /** @private {!{obsolete: boolean, endOfLine: boolean}} */
33 obsoleteSystemInfo_: {
34 type: Object,
35 value: function() {
36 return {
37 obsolete: loadTimeData.getBoolean('aboutObsoleteNowOrSoon'),
38 endOfLine: loadTimeData.getBoolean('aboutObsoleteEndOfTheLine'),
39 };
40 },
41 },
42 }, 45 },
43 46
44 /** @private {?settings.AboutPageBrowserProxy} */ 47 /** @private {?settings.AboutPageBrowserProxy} */
45 aboutBrowserProxy_: null, 48 aboutBrowserProxy_: null,
46 49
47 /** @private {?settings.LifetimeBrowserProxy} */ 50 /** @private {?settings.LifetimeBrowserProxy} */
48 lifetimeBrowserProxy_: null, 51 lifetimeBrowserProxy_: null,
49 52
50 /** @override */ 53 /** @override */
51 attached: function() { 54 attached: function() {
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 }); 296 });
294 }, 297 },
295 298
296 <if expr="_google_chrome"> 299 <if expr="_google_chrome">
297 /** @private */ 300 /** @private */
298 onReportIssueTap_: function() { 301 onReportIssueTap_: function() {
299 this.aboutBrowserProxy_.openFeedbackDialog(); 302 this.aboutBrowserProxy_.openFeedbackDialog();
300 }, 303 },
301 </if> 304 </if>
302 }); 305 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698