Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2421743003:
Fix race in TraceLog::AddEventWithTimestamp (Closed)
DescriptionFix race in TraceLog::AddEventWithTimestamp
The enabled_modes_ cannot be accessed without lock. This CL changes
it to check if the current category is enabled to initialize thread
local.
Tsan build fail:
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20TSan%20Tests/
BUG=625170
TBR=primiano@chromium.org
Committed: https://crrev.com/7d0a5a15a80334107d48b415ce246bc1e6e4b147
Cr-Commit-Position: refs/heads/master@{#425500}
Patch Set 1 : Remove extra changes. #
Messages
Total messages: 20 (14 generated)
Description was changed from ========== Fix race in TraceLog::AddEventWithTimestamp The enabled_modes_ cannot be accessed without lock. This CL changes it to check if the current category is enabled to initialize thread local. BUG=625170 R=oysteine@chromium.org, primiano@chromium.org ========== to ========== Fix race in TraceLog::AddEventWithTimestamp The enabled_modes_ cannot be accessed without lock. This CL changes it to check if the current category is enabled to initialize thread local. Tsan build fail: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20TSan%20Tests/ BUG=625170 R=oysteine@chromium.org, primiano@chromium.org ==========
ptal thanks.
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was checked by ssid@chromium.org
The CQ bit was unchecked by ssid@chromium.org
The CQ bit was checked by ssid@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Description was changed from ========== Fix race in TraceLog::AddEventWithTimestamp The enabled_modes_ cannot be accessed without lock. This CL changes it to check if the current category is enabled to initialize thread local. Tsan build fail: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20TSan%20Tests/ BUG=625170 R=oysteine@chromium.org, primiano@chromium.org ========== to ========== Fix race in TraceLog::AddEventWithTimestamp The enabled_modes_ cannot be accessed without lock. This CL changes it to check if the current category is enabled to initialize thread local. Tsan build fail: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20TSan%20Tests/ BUG=625170 TBR=primiano@chromium.org ==========
@primiano, please see this change this since you had some concern about the local buffer being not initialized in some cases.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ssid@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix race in TraceLog::AddEventWithTimestamp The enabled_modes_ cannot be accessed without lock. This CL changes it to check if the current category is enabled to initialize thread local. Tsan build fail: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20TSan%20Tests/ BUG=625170 TBR=primiano@chromium.org ========== to ========== Fix race in TraceLog::AddEventWithTimestamp The enabled_modes_ cannot be accessed without lock. This CL changes it to check if the current category is enabled to initialize thread local. Tsan build fail: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20TSan%20Tests/ BUG=625170 TBR=primiano@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix race in TraceLog::AddEventWithTimestamp The enabled_modes_ cannot be accessed without lock. This CL changes it to check if the current category is enabled to initialize thread local. Tsan build fail: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20TSan%20Tests/ BUG=625170 TBR=primiano@chromium.org ========== to ========== Fix race in TraceLog::AddEventWithTimestamp The enabled_modes_ cannot be accessed without lock. This CL changes it to check if the current category is enabled to initialize thread local. Tsan build fail: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20TSan%20Tests/ BUG=625170 TBR=primiano@chromium.org Committed: https://crrev.com/7d0a5a15a80334107d48b415ce246bc1e6e4b147 Cr-Commit-Position: refs/heads/master@{#425500} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7d0a5a15a80334107d48b415ce246bc1e6e4b147 Cr-Commit-Position: refs/heads/master@{#425500} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
