Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: scripts/slave/recipe_modules/test_utils/api.py

Issue 2421733002: Archive retry summary for layout tests along with layout test results. (Closed)
Patch Set: Change --retry-summary to --retry-summary-json and make it take a file path Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/test_utils/api.py
diff --git a/scripts/slave/recipe_modules/test_utils/api.py b/scripts/slave/recipe_modules/test_utils/api.py
index eefa6192145af84abde843bc1fab202f42ea3579..2418dc10b96fd77b898fb2985f57c6f2197c9030 100644
--- a/scripts/slave/recipe_modules/test_utils/api.py
+++ b/scripts/slave/recipe_modules/test_utils/api.py
@@ -195,6 +195,25 @@ class TestUtilsApi(recipe_api.RecipeApi):
elif ignored_failures:
self.m.step.active_result.presentation.status = self.m.step.WARNING
+ if test.name == 'webkit_tests':
+ self._archive_retry_summary({
+ 'failures': sorted(new_failures),
+ 'ignored': sorted(ignored_failures)
+ })
+
+ def _archive_retry_summary(self, retry_summary):
+ """Archives the retry summary as JSON, storing it alongside the results
+ from the first run."""
+ script = self.m.chromium.package_repo_resource(
+ 'scripts', 'slave', 'chromium', 'archive_layout_test_retry_summary.py')
+ args = [
+ '--retry-summary-json', self.m.json.input(retry_summary),
+ '--build-number', self.m.properties['buildnumber'],
+ '--builder-name', self.m.properties['buildername'],
+ '--gs-bucket', 'gs://chromium-layout-test-archives',
+ ]
+ self.m.python('archive_retry_summary', script, args)
+
def create_results_from_json(self, data):
return TestResults(data)
@@ -219,4 +238,3 @@ class TestUtilsApi(recipe_api.RecipeApi):
The test_results will be an instance of the GTestResults class.
"""
return GTestResultsOutputPlaceholder(self, add_json_log)
-

Powered by Google App Engine
This is Rietveld 408576698