Archive retry summary for layout tests along with layout test results.

scripts/slave/recipe_modules/test_utils/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from recipe_engine import recipe_api
 from recipe_engine import util as recipe_util
 
 from .util import GTestResults, TestResults
 
 # TODO(luqui): Destroy this DEPS hack.
@@ skipping 177 matching lines @@
       if new_failures:
         self.m.python.failing_step(step_name, step_text)
       else:
         self.m.python.succeeding_step(step_name, step_text)
     finally:
       if new_failures:
         self.m.tryserver.set_test_failure_tryjob_result()
       elif ignored_failures:
         self.m.step.active_result.presentation.status = self.m.step.WARNING
 
+    if test.name == 'webkit_tests':
+        self._archive_retry_summary({
+            'failures': sorted(new_failures),
+            'ignored': sorted(ignored_failures)
+        })
+
+  def _archive_retry_summary(self, retry_summary):
+    """Archives the retry summary as JSON, storing it alongside the results
+    from the first run."""
+    script = self.m.chromium.package_repo_resource(
+        'scripts', 'slave', 'chromium', 'archive_layout_test_retry_summary.py')
+    args = [
+        '--retry-summary', self.m.json.dumps(retry_summary),

[Dirk Pranke, 2016/10/15 22:34:36]

Passing this as a command line argument seems awkward; I'd write it to a file
instead.

+        '--build-number', self.m.properties['buildnumber'],
+        '--builder-name', self.m.properties['buildername'],
+        '--gs-bucket', 'gs://chromium-layout-test-archives',
+        '--staging-dir', self.m.path['cache'].join('chrome_staging'),
+    ]
+    self.m.python('archive_retry_summary', script, args)
+
   def create_results_from_json(self, data):
     return TestResults(data)
 
   @recipe_util.returns_placeholder
   def test_results(self, add_json_log=True):
     """A placeholder which will expand to '/tmp/file'.
 
     The recipe must provide the expected --json-test-results flag.
 
     The test_results will be an instance of the TestResults class.
     """
     return TestResultsOutputPlaceholder(self, add_json_log)
 
   @recipe_util.returns_placeholder
   def gtest_results(self, add_json_log=True):
     """A placeholder which will expand to
     '--test-launcher-summary-output=/tmp/file'.
 
     Provides the --test-launcher-summary-output flag since --flag=value
     (i.e. a single token in the command line) is the required format.
 
     The test_results will be an instance of the GTestResults class.
     """
     return GTestResultsOutputPlaceholder(self, add_json_log)
-