Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: device/bluetooth/dbus/bluetooth_device_client.h

Issue 2421713002: arc: bluetooth: Expose missing advertise data. (Closed)
Patch Set: Fix comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_BLUETOOTH_DBUS_BLUETOOTH_DEVICE_CLIENT_H_ 5 #ifndef DEVICE_BLUETOOTH_DBUS_BLUETOOTH_DEVICE_CLIENT_H_
6 #define DEVICE_BLUETOOTH_DBUS_BLUETOOTH_DEVICE_CLIENT_H_ 6 #define DEVICE_BLUETOOTH_DBUS_BLUETOOTH_DEVICE_CLIENT_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 // give false positives. Read-only. 102 // give false positives. Read-only.
103 dbus::Property<bool> legacy_pairing; 103 dbus::Property<bool> legacy_pairing;
104 104
105 // Remote Device ID information in Linux kernel modalias format. Read-only. 105 // Remote Device ID information in Linux kernel modalias format. Read-only.
106 dbus::Property<std::string> modalias; 106 dbus::Property<std::string> modalias;
107 107
108 // Received signal strength indicator that is set when the device is 108 // Received signal strength indicator that is set when the device is
109 // discovered during inquiry. Read-only. 109 // discovered during inquiry. Read-only.
110 dbus::Property<int16_t> rssi; 110 dbus::Property<int16_t> rssi;
111 111
112 // Manufacturer specific advertisement data. Keys are 16 bits Manufacturer
113 // ID followed by its byte array value. Read-only.
114 dbus::Property<std::unordered_map<uint16_t, std::vector<uint8_t>>>
115 manufacturer_data;
116
112 // Service advertisement data. Keys are the UUIDs in string format followed 117 // Service advertisement data. Keys are the UUIDs in string format followed
113 // by its byte array value. Read-only. 118 // by its byte array value. Read-only.
114 dbus::Property<std::unordered_map<std::string, std::vector<uint8_t>>> 119 dbus::Property<std::unordered_map<std::string, std::vector<uint8_t>>>
115 service_data; 120 service_data;
116 121
117 // Indicate whether or not service discovery has been resolved. Read-only. 122 // Indicate whether or not service discovery has been resolved. Read-only.
118 dbus::Property<bool> services_resolved; 123 dbus::Property<bool> services_resolved;
119 124
125 // The Advertising Data Flags of the remote device. Read-only.
126 dbus::Property<std::vector<uint8_t>> advertising_data_flags;
ortuno 2016/11/02 23:36:48 q: Why is this a vector?
puthik_chromium 2016/11/02 23:44:13 It's what upstream want for future proof. Only the
ortuno 2016/11/02 23:48:13 I see.
127
120 Properties(dbus::ObjectProxy* object_proxy, 128 Properties(dbus::ObjectProxy* object_proxy,
121 const std::string& interface_name, 129 const std::string& interface_name,
122 const PropertyChangedCallback& callback); 130 const PropertyChangedCallback& callback);
123 ~Properties() override; 131 ~Properties() override;
124 }; 132 };
125 133
126 // Interface for observing changes from a remote bluetooth device. 134 // Interface for observing changes from a remote bluetooth device.
127 class Observer { 135 class Observer {
128 public: 136 public:
129 virtual ~Observer() {} 137 virtual ~Observer() {}
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 protected: 239 protected:
232 BluetoothDeviceClient(); 240 BluetoothDeviceClient();
233 241
234 private: 242 private:
235 DISALLOW_COPY_AND_ASSIGN(BluetoothDeviceClient); 243 DISALLOW_COPY_AND_ASSIGN(BluetoothDeviceClient);
236 }; 244 };
237 245
238 } // namespace bluez 246 } // namespace bluez
239 247
240 #endif // DEVICE_BLUETOOTH_DBUS_BLUETOOTH_DEVICE_CLIENT_H_ 248 #endif // DEVICE_BLUETOOTH_DBUS_BLUETOOTH_DEVICE_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698