arc: bluetooth: Expose missing advertise data.

device/bluetooth/bluez/bluetooth_device_bluez.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluez/bluetooth_device_bluez.h"
 
 #include <stdio.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 357 matching lines @@
   UUIDSet uuids;
   const std::vector<std::string>& dbus_uuids = properties->uuids.value();
   for (const std::string& dbus_uuid : dbus_uuids) {
     device::BluetoothUUID uuid(dbus_uuid);
     DCHECK(uuid.IsValid());
     uuids.insert(std::move(uuid));
   }
   return uuids;
 }
 
+base::Optional<uint8_t> BluetoothDeviceBlueZ::GetAdvertisingDataFlags() const {

[ortuno, 2016/10/18 01:41:19]

Also please follow the same pattern as ManufacturerData. All advertising data
should follow that pattern.

[puthik_chromium, 2016/11/02 23:20:38]

Done.

+  bluez::BluetoothDeviceClient::Properties* properties =
+      bluez::BluezDBusManager::Get()->GetBluetoothDeviceClient()->GetProperties(
+          object_path_);
+  DCHECK(properties);
+
+  if (properties->advertising_data_flags.is_valid())
+    return properties->advertising_data_flags.value();
+  return base::nullopt;
+}
+
 base::Optional<int8_t> BluetoothDeviceBlueZ::GetInquiryRSSI() const {
   bluez::BluetoothDeviceClient::Properties* properties =
       bluez::BluezDBusManager::Get()->GetBluetoothDeviceClient()->GetProperties(
           object_path_);
   DCHECK(properties);
 
   if (!properties->rssi.is_valid())
     return base::nullopt;
 
   // BlueZ uses int16_t because there is no int8_t for DBus, so we should never
@@ skipping 212 matching lines @@
       bluez::BluezDBusManager::Get()->GetBluetoothDeviceClient()->GetProperties(
           object_path_);
   DCHECK(properties);
   DCHECK(properties->service_data.is_valid());
 
   service_data_.clear();
   for (const auto& pair : properties->service_data.value())
     service_data_[BluetoothUUID(pair.first)] = pair.second;
 }
 
+void BluetoothDeviceBlueZ::UpdateManufacturerData() {
+  bluez::BluetoothDeviceClient::Properties* properties =
+      bluez::BluezDBusManager::Get()->GetBluetoothDeviceClient()->GetProperties(
+          object_path_);
+  DCHECK(properties);
+  DCHECK(properties->manufacturer_data.is_valid());

[ortuno, 2016/10/18 01:41:18]

manufacturer data is optional so this would is not always true. Also seems we
missed this detail with service data. Could you open an issue regarding this and
if possible send out a patch to fix?

[puthik_chromium, 2016/11/02 23:20:38]

Done.

+
+  manufacturer_data_.clear();
+  for (const auto& pair : properties->manufacturer_data.value())
+    manufacturer_data_[pair.first] = pair.second;
+}
+
 BluetoothPairingBlueZ* BluetoothDeviceBlueZ::BeginPairing(
     BluetoothDevice::PairingDelegate* pairing_delegate) {
   pairing_.reset(new BluetoothPairingBlueZ(this, pairing_delegate));
   return pairing_.get();
 }
 
 void BluetoothDeviceBlueZ::EndPairing() {
   pairing_.reset();
 }
 
@@ skipping 293 matching lines @@
 void BluetoothDeviceBlueZ::OnForgetError(const ErrorCallback& error_callback,
                                          const std::string& error_name,
                                          const std::string& error_message) {
   LOG(WARNING) << object_path_.value()
                << ": Failed to remove device: " << error_name << ": "
                << error_message;
   error_callback.Run();
 }
 
 }  // namespace bluez