Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 24217003: Revert 224101 "Remove dependency on Skia from chromoting client." (Closed)

Created:
7 years, 3 months ago by Sergey Ulanov
Modified:
7 years, 3 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 224101 "Remove dependency on Skia from chromoting client." > Remove dependency on Skia from chromoting client. > > Now DesktopRegion, DesktopRect and DesktopSize are used instead of > corresponding skia types. > > TBR=reed@google.com (for _moved_ skia dependency) > > Review URL: https://chromiumcodereview.appspot.com/23440046 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -510 lines) Patch
M trunk/src/remoting/DEPS View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/remoting/base/util.h View 4 chunks +20 lines, -24 lines 0 comments Download
M trunk/src/remoting/base/util.cc View 6 chunks +63 lines, -74 lines 0 comments Download
M trunk/src/remoting/base/util_unittest.cc View 8 chunks +32 lines, -29 lines 0 comments Download
M trunk/src/remoting/client/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/remoting/client/frame_consumer.h View 3 chunks +8 lines, -9 lines 0 comments Download
M trunk/src/remoting/client/frame_consumer_proxy.h View 1 chunk +5 lines, -5 lines 0 comments Download
M trunk/src/remoting/client/frame_consumer_proxy.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M trunk/src/remoting/client/frame_producer.h View 3 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/remoting/client/jni/jni_frame_consumer.h View 3 chunks +7 lines, -8 lines 0 comments Download
M trunk/src/remoting/client/jni/jni_frame_consumer.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M trunk/src/remoting/client/plugin/chromoting_instance.h View 4 chunks +6 lines, -10 lines 0 comments Download
M trunk/src/remoting/client/plugin/chromoting_instance.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M trunk/src/remoting/client/plugin/pepper_view.h View 5 chunks +16 lines, -18 lines 0 comments Download
M trunk/src/remoting/client/plugin/pepper_view.cc View 11 chunks +33 lines, -27 lines 0 comments Download
M trunk/src/remoting/client/rectangle_update_decoder.h View 3 chunks +8 lines, -10 lines 0 comments Download
M trunk/src/remoting/client/rectangle_update_decoder.cc View 7 chunks +24 lines, -22 lines 0 comments Download
M trunk/src/remoting/codec/codec_test.cc View 6 chunks +17 lines, -14 lines 0 comments Download
M trunk/src/remoting/codec/video_decoder.h View 4 chunks +10 lines, -13 lines 0 comments Download
M trunk/src/remoting/codec/video_decoder_verbatim.h View 2 chunks +9 lines, -11 lines 0 comments Download
M trunk/src/remoting/codec/video_decoder_verbatim.cc View 6 chunks +31 lines, -32 lines 0 comments Download
M trunk/src/remoting/codec/video_decoder_vp8.h View 4 chunks +14 lines, -18 lines 0 comments Download
M trunk/src/remoting/codec/video_decoder_vp8.cc View 8 chunks +80 lines, -83 lines 0 comments Download
M trunk/src/remoting/codec/video_encoder_vp8.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/remoting/codec/video_encoder_vp8.cc View 6 chunks +20 lines, -26 lines 0 comments Download
M trunk/src/remoting/host/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/remoting/host/mouse_clamping_filter.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/remoting/protocol/input_event_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/remoting/protocol/input_event_tracker.cc View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/remoting/protocol/mouse_input_filter.h View 2 chunks +6 lines, -5 lines 0 comments Download
M trunk/src/remoting/protocol/mouse_input_filter.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M trunk/src/remoting/protocol/mouse_input_filter_unittest.cc View 7 chunks +16 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sergey Ulanov
7 years, 3 months ago (2013-09-19 21:23:47 UTC) #1
Sergey Ulanov
7 years, 3 months ago (2013-09-19 21:24:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r224205.

Powered by Google App Engine
This is Rietveld 408576698