Fix the look of download success notification

Fix the look of download success notification

There are some new resources files from rachelis.
And also fixing the background color on the success notification.

BUG=648221
Committed: https://crrev.com/83365b64f51e17c80f9f99f11c342e74aa8b67c2
Cr-Commit-Position: refs/heads/master@{#425399}

[qinmin, 2016-10-13 22:54:55]

qinmin@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[qinmin, 2016-10-13 22:54:56]

PTAL. png file is already optimized

[gone, 2016-10-14 00:46:05]

https://chromiumcodereview.appspot.com/2421693002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://chromiumcodereview.appspot.com/2421693002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:482:
paint.setColor(Color.parseColor("#607D8B"));
Can you add this to colors.xml?  Don't want random hex colors defined in the
code more often than they already are.

[qinmin, 2016-10-14 17:32:23]

https://codereview.chromium.org/2421693002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2421693002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:482:
paint.setColor(Color.parseColor("#607D8B"));
On 2016/10/14 00:46:05, dfalcantara (OOO 10.17-10.23) wrote:
> Can you add this to colors.xml?  Don't want random hex colors defined in the
> code more often than they already are.

Done.

[gone, 2016-10-14 17:35:43]

lgtm

https://codereview.chromium.org/2421693002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2421693002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:481:
paint.setColor(resources.getColor(R.color.google_blue_grey_500));
I think you need to use ApiCompatibilityUtils.getColor because M changed the
interface.

[qinmin, 2016-10-14 18:00:49]

https://codereview.chromium.org/2421693002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2421693002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:481:
paint.setColor(resources.getColor(R.color.google_blue_grey_500));
On 2016/10/14 17:35:43, dfalcantara (OOO 10.17-10.23) wrote:
> I think you need to use ApiCompatibilityUtils.getColor because M changed the
> interface.

Done. Thanks for the info, it's bad that the android APIs will change

[qinmin, 2016-10-14 18:01:00]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-10-14 18:01:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2421693002/#ps40001
(title: "use ApiCompatibilityUtils to get color")

[commit-bot: I haz the power, 2016-10-14 18:02:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 18:40:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-14 18:42:25]

Description was changed from

==========
Fix the look of download success notification

There are some new resources files from rachelis.
And also fixing the background color on the success notification.

BUG=648221
==========

to

==========
Fix the look of download success notification

There are some new resources files from rachelis.
And also fixing the background color on the success notification.

BUG=648221

Committed: https://crrev.com/83365b64f51e17c80f9f99f11c342e74aa8b67c2
Cr-Commit-Position: refs/heads/master@{#425399}
==========

[commit-bot: I haz the power, 2016-10-14 18:42:26]

Patchset 3 (id:??) landed as
https://crrev.com/83365b64f51e17c80f9f99f11c342e74aa8b67c2
Cr-Commit-Position: refs/heads/master@{#425399}